From: Josh Triplett <josh@freedesktop.org>
To: Christopher Li <sparse@chrisli.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Anton Altaparmakov <aia21@cam.ac.uk>,
Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] Re: Sparse just seg faulted on me!
Date: Thu, 22 Feb 2007 18:25:30 -0800 [thread overview]
Message-ID: <45DE509A.4040002@freedesktop.org> (raw)
In-Reply-To: <20070214201855.GC18753@chrisli.org>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
Christopher Li wrote:
> On Wed, Feb 14, 2007 at 11:54:47AM -0800, Christopher Li wrote:
>> On Wed, Feb 14, 2007 at 10:24:09AM -0800, Linus Torvalds wrote:
>>> Actually, it's often better to just explicitly make "ctype" be
>>> "&bad_ctype" instead.
>>>
>>> It's nice if a NULL type means "type has not been evaluated yet", and then
>>> using "&bad_ctype" to mean "type evaluated to crap".
>> Good idea. Some of the code already doing that. I am making it as a separate
>> patch because touch a lot of code.
>
> This is very messy. The current evaluate_* functions are assuming NULL means for
> "some error happen in this expression, I can't get the ctype". It is all over the
> place.
In that case, I will go ahead and apply your patch to eliminate the segfault, and
I can merge a new patch that uses &bad_ctype later.
- Josh Triplett
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
next prev parent reply other threads:[~2007-02-23 2:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 9:04 Sparse just seg faulted on me! Anton Altaparmakov
2007-02-14 17:29 ` [PATCH] " Christopher Li
2007-02-14 18:24 ` Linus Torvalds
2007-02-14 19:54 ` Christopher Li
2007-02-14 20:18 ` Christopher Li
2007-02-23 2:25 ` Josh Triplett [this message]
2007-02-14 20:48 ` Linus Torvalds
2007-02-14 20:36 ` Christopher Li
2007-02-23 2:42 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DE509A.4040002@freedesktop.org \
--to=josh@freedesktop.org \
--cc=aia21@cam.ac.uk \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).