[PATCH 2] Fix core dump on anonymous symbol.

[PATCH 2] Fix core dump on anonymous symbol.

[Christopher Li]

Using the following can generate anonymous symbol without
initializer expression.

	return (struct foo) {};

It would be nice if sparse does not crash on it.

Signed-Off-By: Christopher Li <sparse@chrisli.org>

Index: sparse/linearize.c
===================================================================
--- sparse.orig/linearize.c	2007-01-30 19:47:10.000000000 -0800
+++ sparse/linearize.c	2007-01-30 19:47:54.000000000 -0800
@@ -116,14 +116,16 @@ const char *show_pseudo(pseudo_t pseudo)
 		}
 		expr = sym->initializer;
 		snprintf(buf, 64, "<anon symbol:%p>", sym);
-		switch (expr->type) {
-		case EXPR_VALUE:
-			snprintf(buf, 64, "<symbol value: %lld>", expr->value);
-			break;
-		case EXPR_STRING:
-			return show_string(expr->string);
-		default:
-			break;
+		if (expr) {
+			switch (expr->type) {
+			case EXPR_VALUE:
+				snprintf(buf, 64, "<symbol value: %lld>", expr->value);
+				break;
+			case EXPR_STRING:
+				return show_string(expr->string);
+			default:
+				break;
+			}
 		}
 		break;
 	}

Re: [PATCH 2] Fix core dump on anonymous symbol.

[Josh Triplett]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Christopher Li wrote:
> Using the following can generate anonymous symbol without
> initializer expression.
> 
> 	return (struct foo) {};
> 
> It would be nice if sparse does not crash on it.
> 
> Signed-Off-By: Christopher Li <sparse@chrisli.org>

I tried several variants of the code you suggest, but I couldn't seem to
reproduce the problem this solves.  Could you supply a full .c file for a test
case?

In any case, applied.

- Josh Triplett


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]