From: Josh Triplett <josh@freedesktop.org>
To: Christopher Li <sparse@chrisli.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 3] Fix core dump on huge switch
Date: Mon, 26 Feb 2007 11:57:28 -0800 [thread overview]
Message-ID: <45E33BA8.80904@freedesktop.org> (raw)
In-Reply-To: <20070210001647.GB20644@chrisli.org>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
Christopher Li wrote:
> Bump up the size of the instruction buffer. vt_ioctl.c has
> a huge switch statement causing sparse over flow the instruction
> buffer.
>
> Signed-Off-By: Christopher Li <sparse@chrisli.org>
I've applied this fix for now, to solve the immediate problem; thanks for the patch.
Ideally I'd like to see some solution that grows the buffer as needed.
I also committed one minor style fix after your patch:
> + if (buf >= buffer + sizeof buffer)
Please use parentheses with sizeof, per the Linux Documentation/CodingStyle.
- Josh Triplett
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
prev parent reply other threads:[~2007-02-26 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-10 0:16 [PATCH 3] Fix core dump on huge switch Christopher Li
2007-02-26 19:57 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E33BA8.80904@freedesktop.org \
--to=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).