From: Josh Triplett <josh@freedesktop.org>
To: Christopher Li <sparse@chrisli.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>, linux-sparse@vger.kernel.org
Subject: Re: barrier macro
Date: Wed, 02 May 2007 11:11:00 -0700 [thread overview]
Message-ID: <4638D434.7010205@freedesktop.org> (raw)
In-Reply-To: <20070502072056.GA9889@chrisli.org>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
Christopher Li wrote:
> On Tue, May 01, 2007 at 10:37:11PM -0700, Josh Triplett wrote:
>> Fixed in current Git.
>
> May I purpose a slightly different fix?
>
> The reason I use bit mask in the keyword so that it can allow
> select a sub set of keywords. If we want, We can fine tune exactly
> what keyword is allowed. It also makes the caller of handle_attributes
> show exactly what kind of attribute it takes.
Applied, with a minor fix: a bitmask of values from "enum keyword" does not
have type "enum keyword", so I made the argument an unsigned int.
- Josh Triplett
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
prev parent reply other threads:[~2007-05-02 18:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 22:34 barrier macro Randy Dunlap
2007-05-02 3:17 ` Josh Triplett
2007-05-02 4:04 ` Randy Dunlap
2007-05-02 4:11 ` Josh Triplett
2007-05-02 4:24 ` Josh Triplett
2007-05-02 4:35 ` Randy Dunlap
2007-05-02 5:37 ` Josh Triplett
2007-05-02 7:20 ` Christopher Li
2007-05-02 18:11 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4638D434.7010205@freedesktop.org \
--to=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).