[PATCH 0/5] Sparse on Cygwin (and git).

[PATCH 0/5] Sparse on Cygwin (and git).

[Ramsay Jones]

[-- Attachment #1: Type: text/plain, Size: 2358 bytes --]

Hi Josh,

Since git uses sparse in it's "check" make target, I decided to download the
(then current) 0.2 tar-ball and see what sparse was about. Unfortunately, at present,
I am using cygwin on win32 until I get around to installing Linux. ;-)
Hence, the following patch series...

0001-Add-support-for-WIN32-attribute-names.patch
0002-Fix-an-__attribute__-parsing-error.patch
0003-Add-cygwin-support-to-cgcc.patch
0004-Fix-a-Wtypesign-bug.patch

Well, when the 0.3 tar-ball was released, I had to update the patch series.
Changes to the attribute parsing code meant an update to patch 0001 was
required. Patch 0004 now seems to be unnecessary (probably due to commit
ef2596162115bfdc2a1d3639ac99dd3ba2a71af2). Also compilation errors lead to
the introduction of two new patches (1&2/5), as follows ...

0001-Fix-an-attribute-__sentinel__-unknown-warning.patch
0002-Fix-some-enum-value-XXX-not-handled-in-switch-wa.patch
0003-Add-support-for-WIN32-attribute-names.patch
0004-Fix-an-__attribute__-parsing-error.patch
0005-Add-cygwin-support-to-cgcc.patch

As I am somewhat bandwidth challenged, until recently, I had never cloned a
git repository (not even the git repo). So, last week I cloned the sparse
repository; thankfully it only took about ten minutes (yep a slow pipe!).
Thus, again I had to update the patch series. Patch 0003 overlapped a
recent commit (baf2c5a8) by Michael Stefaniuc and patch 0004 required an
update due to handle_attributes() gaining a third parameter. So the final
patch series is:

0001-Fix-an-__sentinel__-attribute-directive-ignored.patch
0002-Fix-some-enum-value-XXX-not-handled-in-switch-wa.patch
0003-Add-more-support-for-WIN32-attribute-names.patch
0004-Fix-an-__attribute__-parsing-error.patch
0005-Add-cygwin-support-to-cgcc.patch

which was built on top of: 0.3-15-gb5bd30f

I have attached "0004-Fix-a-Wtypesign-bug.patch" simply out of interest, as
it does not require the parameter type of "function returning..." to decay to
"pointer to function returning...".  The test case comes from git:

$cat tsb.c

typedef int erf(const char *r, const unsigned char *s, int f, void *c);

extern int fer(erf, void *);

static int ar(const char *r, const unsigned char *s, int f, void *c)
{
	return 0;
}

int main (int argc, char *argv[])
{
	fer(ar, (void *)0);
}

$

Hope you find this useful.

All the best,

Ramsay Jones


[-- Attachment #2: 0004-Fix-a-Wtypesign-bug.patch --]
[-- Type: application/xxxxx, Size: 1583 bytes --]

[-- Attachment #3: tsb.c --]
[-- Type: text/plain, Size: 249 bytes --]


typedef int erf(const char *r, const unsigned char *s, int f, void *c);

extern int fer(erf, void *);

static int ar(const char *r, const unsigned char *s, int f, void *c)
{
	return 0;
}

int main (int argc, char *argv[])
{
	fer(ar, (void *)0);
}

Re: [PATCH 0/5] Sparse on Cygwin (and git).

[Josh Triplett]

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

Ramsay Jones wrote:
> Since git uses sparse in it's "check" make target,

Cool; I didn't know that. :)

> I decided to download the
> (then current) 0.2 tar-ball and see what sparse was about.

Great!

> Unfortunately, at present,
> I am using cygwin on win32 until I get around to installing Linux. ;-)

Fortunately, that resulted in some excellent patches. :)

[...]
> As I am somewhat bandwidth challenged, until recently, I had never cloned a
> git repository (not even the git repo). So, last week I cloned the sparse
> repository; thankfully it only took about ten minutes (yep a slow pipe!).

I think you'll find that keeping the git repo up-to-date requires quite a bit
less bandwidth than the initial checkout.

> Thus, again I had to update the patch series.

In general, you'll probably run into conflicts if you try to generate patches
from the last release tarball, especially on frequently changed files like
ident-list.h and the attribute table.

> Patch 0003 overlapped a
> recent commit (baf2c5a8) by Michael Stefaniuc and patch 0004 required an
> update due to handle_attributes() gaining a third parameter. So the final
> patch series is:
> 
> 0001-Fix-an-__sentinel__-attribute-directive-ignored.patch
> 0002-Fix-some-enum-value-XXX-not-handled-in-switch-wa.patch
> 0003-Add-more-support-for-WIN32-attribute-names.patch
> 0004-Fix-an-__attribute__-parsing-error.patch
> 0005-Add-cygwin-support-to-cgcc.patch
> 
> which was built on top of: 0.3-15-gb5bd30f

Looks like a good set of patches.  However, only patches 3 and 4 seem to have
hit the list.

- Josh Triplett



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

Re: [PATCH 0/5] Sparse on Cygwin (and git).

[Ramsay Jones]

Josh Triplett wrote:
> Ramsay Jones wrote:
>> Since git uses sparse in it's "check" make target,
> 
> Cool; I didn't know that. :)
heh, I don't know how often git developers "make check" ;-)

[...]
>> Unfortunately, at present,
>> I am using cygwin on win32 until I get around to installing Linux. ;-)
> 
> Fortunately, that resulted in some excellent patches. :)
> 
Apart from the whitespace breakage!

> [...]
>> 0001-Fix-an-__sentinel__-attribute-directive-ignored.patch
>> 0002-Fix-some-enum-value-...-not-handled-in-switch-wa.patch
>> 0003-Add-more-support-for-WIN32-attribute-names.patch
>> 0004-Fix-an-__attribute__-parsing-error.patch
>> 0005-Add-cygwin-support-to-cgcc.patch
>>
>> which was built on top of: 0.3-15-gb5bd30f
> 
> Looks like a good set of patches.  However, only patches 3 and 4 seem to have
> hit the list.
> 
Patch 2 was bounced by the vger spam blocker (because of the 3 uppercase x chars).

ATB,

Ramsay Jones