Re: [PATCH 0/5] Sparse on Cygwin (and git).

[Josh Triplett <josh@freedesktop.org>]

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

Ramsay Jones wrote:
> Since git uses sparse in it's "check" make target,

Cool; I didn't know that. :)

> I decided to download the
> (then current) 0.2 tar-ball and see what sparse was about.

Great!

> Unfortunately, at present,
> I am using cygwin on win32 until I get around to installing Linux. ;-)

Fortunately, that resulted in some excellent patches. :)

[...]
> As I am somewhat bandwidth challenged, until recently, I had never cloned a
> git repository (not even the git repo). So, last week I cloned the sparse
> repository; thankfully it only took about ten minutes (yep a slow pipe!).

I think you'll find that keeping the git repo up-to-date requires quite a bit
less bandwidth than the initial checkout.

> Thus, again I had to update the patch series.

In general, you'll probably run into conflicts if you try to generate patches
from the last release tarball, especially on frequently changed files like
ident-list.h and the attribute table.

> Patch 0003 overlapped a
> recent commit (baf2c5a8) by Michael Stefaniuc and patch 0004 required an
> update due to handle_attributes() gaining a third parameter. So the final
> patch series is:
> 
> 0001-Fix-an-__sentinel__-attribute-directive-ignored.patch
> 0002-Fix-some-enum-value-XXX-not-handled-in-switch-wa.patch
> 0003-Add-more-support-for-WIN32-attribute-names.patch
> 0004-Fix-an-__attribute__-parsing-error.patch
> 0005-Add-cygwin-support-to-cgcc.patch
> 
> which was built on top of: 0.3-15-gb5bd30f

Looks like a good set of patches.  However, only patches 3 and 4 seem to have
hit the list.

- Josh Triplett



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]