From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Krzysztof Halasa <khc@pm.waw.pl>,
Josh Triplett <josht@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH] CodingStyle: proscribe do-while without braces.
Date: Fri, 27 Jul 2007 19:13:28 +0200 [thread overview]
Message-ID: <46AA27B8.8060701@s5r6.in-berlin.de> (raw)
In-Reply-To: <20070727005349.512c2f8d.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Fri, 27 Jul 2007 09:41:01 +0200 Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
...
>> SubmitChecklist already tells us to check with sparse before submission.
>
> rofl. First we have to talk everyone into checking their stuff with gcc.
Ah, I forgot --- Real Submitters don't compile their code before
submission. But wait, they also don't track CodingStyle.
Seriously though: Precise rules are a priori welcome. But the more
rules there are, the less of them we (authors, reviewers) can memorize.
If we go for having many rules, then we need to rely more on checkpatch
and sparse. When growing into a catch-all rule book, the utility of
CodingStyle will shift from an author's guide to a specification for
code checking tools.
--
Stefan Richter
-=====-=-=== -=== ==-==
http://arcgraph.de/sr/
next prev parent reply other threads:[~2007-07-27 17:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 21:37 [PATCH] CodingStyle: proscribe do-while without braces Josh Triplett
2007-07-26 21:44 ` Andrew Morton
2007-07-26 21:54 ` Josh Triplett
2007-07-27 0:18 ` Krzysztof Halasa
2007-07-27 0:35 ` Andrew Morton
2007-07-27 16:00 ` Krzysztof Halasa
2007-07-27 17:05 ` Josh Triplett
2007-07-27 17:44 ` Krzysztof Halasa
2007-07-27 18:27 ` Andrew Morton
2007-07-27 18:52 ` Josh Triplett
2007-07-27 0:42 ` Stefan Richter
2007-07-27 0:59 ` Andrew Morton
2007-07-27 7:41 ` Stefan Richter
2007-07-27 7:53 ` Andrew Morton
2007-07-27 17:13 ` Stefan Richter [this message]
2007-07-27 1:17 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AA27B8.8060701@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@linux-foundation.org \
--cc=josht@linux.vnet.ibm.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).