From: Josh Triplett <josh@freedesktop.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Howells <dhowells@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH 2/2] Simplify (and warn about) right shifts that result in zero
Date: Thu, 24 Apr 2008 19:29:56 -0700 [thread overview]
Message-ID: <48114224.2020806@freedesktop.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0804241452250.2779@woody.linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
Linus Torvalds wrote:
> From: Linus Torvalds <torvalds@woody.linux-foundation.org>
> Date: Thu, 24 Apr 2008 14:47:04 -0700
>
> ..due to limited source sizes.
>
> Yeah, should do this for left shifts too.
>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
>
> Again, not a lot of testing, but it _looks_ fairly sane.
>
> The constant value case of "operand_size()" is not actually ever used
> (because a totally constant right shift will be optimized in other
> places), but I wrote the code so that perhaps other cases could use this.
> Whatever.
>
> The "do the same for left shifts" could do a similar check, but based
> purely on the size of the operation, not the size of the operand value.
> Which makes it not very interesting.
Applied and pushed.
- Josh Triplett
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
next prev parent reply other threads:[~2008-04-25 2:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080424193856.14737.16718.stgit@warthog.procyon.org.uk>
[not found] ` <alpine.LFD.1.10.0804241248290.2779@woody.linux-foundation.org>
2008-04-24 21:52 ` [PATCH 1/2] Fix cast instruction generation Linus Torvalds
2008-04-24 21:54 ` [PATCH 2/2] Simplify (and warn about) right shifts that result in zero Linus Torvalds
2008-04-24 23:52 ` Pavel Roskin
2008-04-25 0:03 ` Linus Torvalds
2008-04-25 0:34 ` Pavel Roskin
2008-04-25 2:32 ` Josh Triplett
2008-04-25 2:29 ` Josh Triplett [this message]
2008-04-25 2:24 ` [PATCH 1/2] Fix cast instruction generation Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48114224.2020806@freedesktop.org \
--to=josh@freedesktop.org \
--cc=dhowells@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).