From: Michael Stefaniuc <mstefani@redhat.com>
To: Christopher Li <sparse@chrisli.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: Ignore the ms_abi/sysv_abi attributes.
Date: Wed, 30 Sep 2009 22:21:30 +0200 [thread overview]
Message-ID: <4AC3BDCA.9090300@redhat.com> (raw)
In-Reply-To: <70318cbf0909291630q73f92ab9ma980ca98564f366f@mail.gmail.com>
On 09/30/2009 01:30 AM, Christopher Li wrote:
> On Tue, Sep 29, 2009 at 2:01 PM, Michael Stefaniuc<mstefani@redhat.com> wrote:
>> This is needed for getting a meaningful sparse run on a Wine 64-bit
>> compile. Else the basic Win32 headers will produce tons of
>> error: attribute 'ms_abi': unknown attribute
>> which end in
>> error: too many errors.
>>
>> The sysv_abi attribute was just added for symmetry.
>
> Thanks for the patch. Ignoring the attribute has become so common now.
> I decide stop the complicate way to adding ignored attributes.
>
> I attach two patches to simplify things. I am I am going to push
> them out to chrisl tree.
>
> Can you change your patch base on my new patch?
Done!
> It should be really simple, just add one string for each attribute
> is good enough.
The nicest part about this is that the ignored attributes are now sorted
alphabetically and one doesn't have to figure out where exactly to add them.
thanks
bye
michael
next prev parent reply other threads:[~2009-09-30 20:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 21:01 Ignore the ms_abi/sysv_abi attributes Michael Stefaniuc
2009-09-29 23:30 ` Christopher Li
2009-09-30 20:21 ` Michael Stefaniuc [this message]
2009-09-30 20:49 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC3BDCA.9090300@redhat.com \
--to=mstefani@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).