Linux SPARSE checker discussions
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Christopher Li <sparse@chrisli.org>
Cc: Pekka Enberg <penberg@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: suggestion for Merging LLVM
Date: Tue, 22 Nov 2011 00:52:49 -0500	[thread overview]
Message-ID: <4ECB38B1.8020803@garzik.org> (raw)
In-Reply-To: <CANeU7QkLTOaH7LNiyTEmUOrWb4Tb39+HKM0xPnowL5s0Qbbwyw@mail.gmail.com>

On 11/21/2011 09:43 PM, Christopher Li wrote:
> Hi Pekka,
>
> I already tag the sparse 0.4.4 release in git. Just waiting
> for getting the release directory setup on kernel.org and it
> is ready to go.
>
> Now I am looking at your LLVM repository and the llvm patches.
> I don't have a good sense for the later patch without looking at the
> earlier changes.
>
> I haven't done big repository merge before, this is the first one.
> So I am looking for suggestion what is the best practice here.
>
> Do we care about clean up the history and import the changes
> step by step as patches or just a plain git merge of the LLVM
> repository?

I don't see any reason to import step-by-step as patches.

Either merge it as a single "add incomplete LLVM backend" commit, 
dropping all pre-upstream history, or git merge.

FWIW I am sorta stuck; cannot figure out how to make 'phi' operation in 
LLVM work the way we need it to.  That is a crucial hurdle needed for 
loops.  LLVM fundamentally should be able to do it, but I'm not sure 
this works within the C API.  I was thinking my next step would be to 
whine on the llvm list.

A workaround is to resuscitate unssa() call, and all that entails.

	Jeff






  reply	other threads:[~2011-11-22  5:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22  2:43 suggestion for Merging LLVM Christopher Li
2011-11-22  5:52 ` Jeff Garzik [this message]
2011-11-22  6:01   ` Pekka Enberg
2011-11-22 20:32     ` Jeff Garzik
2011-11-22 20:38       ` Pekka Enberg
2011-11-23  4:11         ` Jeff Garzik
2011-11-23  6:01         ` Jeff Garzik
2011-11-23  6:58           ` Pekka Enberg
2011-11-25  1:45     ` Christopher Li
2011-11-25  2:25       ` Jeff Garzik
2011-11-25  5:52         ` Pekka Enberg
2011-11-25  6:28           ` Christopher Li
2011-11-25  6:43             ` Pekka Enberg
2011-11-25  8:05               ` Christopher Li
2011-11-25  8:29                 ` Pekka Enberg
2011-11-25 17:52                 ` Jeff Garzik
2011-11-25 19:13                   ` Christopher Li
2011-11-25 20:18                     ` Jeff Garzik
2011-11-25 20:30                       ` Christopher Li
2011-12-13 20:29                         ` Pekka Enberg
2011-12-15 21:34                           ` Christopher Li
2011-12-20  8:53                             ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECB38B1.8020803@garzik.org \
    --to=jeff@garzik.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=penberg@kernel.org \
    --cc=sparse@chrisli.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox