linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Xi Wang <xi.wang@gmail.com>, Pekka Enberg <penberg@kernel.org>,
	linux-sparse@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Christopher Li <sparse@chrisli.org>
Subject: Re: [PATCH] fix casts when linearizing compound assignments
Date: Fri, 08 Jun 2012 16:09:11 -0400	[thread overview]
Message-ID: <4FD25BE7.7010900@garzik.org> (raw)
In-Reply-To: <CA+55aFwCMtzW9e0J8zPnUZsBNmCMRPqsL+hpzkMp4nx4sMXbFw@mail.gmail.com>

On 06/08/2012 03:28 PM, Linus Torvalds wrote:
> On Fri, Jun 8, 2012 at 12:25 PM, Xi Wang<xi.wang@gmail.com>  wrote:
>>
>> What I am doing now is to convert all operands to integers first,
>> perform the addition, and then convert the result back to pointer.
>> Anything wrong with that?
>
> Wrong with it? No, it's what all reasonable hardware does anyway. But
> it's possible that it would effectively disable some LVM warnings or
> optimizations.

Yep.  That is the tradeoff.

	Jeff





  parent reply	other threads:[~2012-06-08 20:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08 10:47 [PATCH] fix casts when linearizing compound assignments Xi Wang
2012-06-08 15:45 ` Xi Wang
2012-06-08 19:10   ` Pekka Enberg
2012-06-08 19:18     ` Linus Torvalds
2012-06-08 19:25       ` Xi Wang
2012-06-08 19:28         ` Linus Torvalds
2012-06-08 19:47           ` Pekka Enberg
2012-06-08 19:57             ` Xi Wang
2012-06-08 20:09           ` Jeff Garzik [this message]
2012-06-08 20:08     ` Jeff Garzik
2012-06-08 20:16       ` Linus Torvalds
2012-06-16  6:10         ` Xi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD25BE7.7010900@garzik.org \
    --to=jeff@garzik.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=penberg@kernel.org \
    --cc=sparse@chrisli.org \
    --cc=torvalds@linux-foundation.org \
    --cc=xi.wang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).