From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Daniel Santos <daniel.santos@pobox.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christopher Li <sparse@chrisli.org>,
David Daney <david.daney@cavium.com>,
David Howells <dhowells@redhat.com>,
David Rientjes <rientjes@google.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Ingo Molnar <mingo@kernel.org>, Joe Perches <joe@perches.com>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
linux-doc@vger.kernel.org, linux-sparse@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>, Paul Turner <pjt@google.com>,
Pavel Pisa <pisa@cmp.felk.cvut.cz>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Richard Weinberger <richard@nod.at>,
Rob Landley <rob@landley.net>,
Steven Rostedt <rostedt@goodmis.org>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH v4 6/13] bug.h: Replace __linktime_error with __compiletime_error
Date: Mon, 25 Jun 2012 14:16:28 -0400 [thread overview]
Message-ID: <4FE8AAFC.1080306@windriver.com> (raw)
In-Reply-To: <1340424048-7759-7-git-send-email-daniel.santos@pobox.com>
On 12-06-23 12:00 AM, Daniel Santos wrote:
> Signed-off-by: Daniel Santos <daniel.santos@pobox.com>
> ---
> include/linux/bug.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/bug.h b/include/linux/bug.h
> index aaac4bb..298a916 100644
> --- a/include/linux/bug.h
> +++ b/include/linux/bug.h
> @@ -73,7 +73,7 @@ extern int __build_bug_on_failed;
> #define BUILD_BUG() \
> do { \
> extern void __build_bug_failed(void) \
> - __linktime_error("BUILD_BUG failed"); \
> + __compiletime_error("BUILD_BUG failed");\
At a quick glance of the bug.h parts, I would think you need
this commit _before_ #5 (that deleted __linktime_error) otherwise
you'll have introduced a bisection build failure. Or, alternatively
you could combine #5 and #6 since they are clearly related, and
their separation is more of a per-file CVS mentality than it is of
any existence of distinct and separate/unrelated changesets.
P.
> __build_bug_failed(); \
> } while (0)
>
next prev parent reply other threads:[~2012-06-25 18:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 4:00 [PATCH v4 0/13] Generic Red-Black Trees Daniel Santos
2012-06-23 4:00 ` [PATCH v4 1/13] compiler-gcc4.h: Correct verion check for __compiletime_error Daniel Santos
2012-06-23 4:00 ` [PATCH v4 2/13] compiler-gcc4.h: Reorder macros based upon gcc ver Daniel Santos
2012-06-23 4:00 ` [PATCH v4 3/13] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro Daniel Santos
2012-06-23 4:00 ` [PATCH v4 4/13] compiler-gcc{3,4}.h: Use " Daniel Santos
2012-06-23 4:00 ` [PATCH v4 5/13] compiler{,-gcc4}.h: Remove duplicate macros Daniel Santos
2012-06-23 4:00 ` [PATCH v4 6/13] bug.h: Replace __linktime_error with __compiletime_error Daniel Santos
2012-06-25 18:16 ` Paul Gortmaker [this message]
2012-06-25 19:30 ` Daniel Santos
2012-06-23 4:00 ` [PATCH v4 7/13] compiler{,-gcc4}.h: Introduce __flatten function attribute Daniel Santos
2012-06-23 4:00 ` [PATCH v4 8/13] bug.h: Make BUILD_BUG_ON generate compile-time error Daniel Santos
2012-06-23 4:00 ` [PATCH v4 9/13] bug.h: Add BUILD_BUG_ON_NON_CONST macro Daniel Santos
2012-06-23 4:00 ` [PATCH v4 10/13] bug.h: Add gcc 4.2+ versions of BUILD_BUG_ON_* macros Daniel Santos
2012-06-23 4:00 ` [PATCH v4 11/13] rbtree.h: Generic Red-Black Trees Daniel Santos
2012-06-27 13:00 ` Peter Zijlstra
2012-06-23 4:00 ` [PATCH v4 12/13] fair.c: Use generic rbtree impl in fair scheduler Daniel Santos
2012-06-26 12:15 ` Peter Zijlstra
2012-06-26 21:59 ` Daniel Santos
2012-06-27 12:36 ` Peter Zijlstra
2012-06-23 4:00 ` [PATCH v4 13/13] documentation for rbtrees Daniel Santos
2012-06-23 23:01 ` [PATCH v4 0/13] Generic Red-Black Trees Rob Landley
2012-06-24 0:40 ` Daniel Santos
2012-06-24 4:39 ` Rob Landley
2012-06-24 7:57 ` Pavel Pisa
2012-06-24 23:29 ` Rob Landley
2012-06-25 8:35 ` Daniel Santos
2012-06-24 16:06 ` Alan Cox
2012-06-25 0:33 ` Daniel Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE8AAFC.1080306@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=daniel.santos@pobox.com \
--cc=david.daney@cavium.com \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=khlebnikov@openvz.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=pisa@cmp.felk.cvut.cz \
--cc=pjt@google.com \
--cc=richard@nod.at \
--cc=rientjes@google.com \
--cc=rob@landley.net \
--cc=rostedt@goodmis.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=sparse@chrisli.org \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).