From: Mauro Dreissig <mukadr@gmail.com>
To: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 2/2] ptrlist.c: fix a typo in a comment
Date: Thu, 02 Aug 2012 11:56:34 -0300 [thread overview]
Message-ID: <501A9522.8030802@gmail.com> (raw)
In-Reply-To: <5019ED0F.6080507@gmail.com>
On 08/01/2012 11:59 PM, Mauro Dreissig wrote:
> On 06/18/2012 06:39 PM, Jonathan Neuschäfer wrote:
>> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>> ---
>> ptrlist.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ptrlist.c b/ptrlist.c
>> index 2620412..5dc1117 100644
>> --- a/ptrlist.c
>> +++ b/ptrlist.c
>> @@ -35,7 +35,7 @@ int ptr_list_size(struct ptr_list *head)
>> *
>> * The array to linearize into (second argument) should really
>> * be "void *x[]", but we want to let people fill in any kind
>> - * of pointer array, so let's just call it "void *".
>> + * of pointer array, so let's just call it "void **".
>> */
>> int linearize_ptr_list(struct ptr_list *head, void **arr, int max)
>> {
>>
>
> Hi!
>
> It looks like the comment was left there by mistake. I belive the idea
> was to call the second argument void * to avoid warnings when passing
> other_type ** to the function without having to cast it to void **.
>
> Reading the comment now only gives the idea that declaring the argument
> as void ** instead of void *[] gives different semantics, which is not the case.
>
> Mauro
>
Ah, I think I get it.. You cant cast something to "void *[]". sry :P
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-08-02 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 21:39 [PATCH 1/2] FAQ: update the website address and call it Wiki Jonathan Neuschäfer
2012-06-18 21:39 ` [PATCH 2/2] ptrlist.c: fix a typo in a comment Jonathan Neuschäfer
2012-06-26 7:55 ` Christopher Li
2012-06-26 19:59 ` Jonathan Neuschäfer
2012-08-02 2:59 ` Mauro Dreissig
2012-08-02 14:56 ` Mauro Dreissig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501A9522.8030802@gmail.com \
--to=mukadr@gmail.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).