From: Daniel Santos <danielfsantos@att.net>
To: Josh Triplett <josh@joshtriplett.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Daniel Santos <daniel.santos@pobox.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-sparse@vger.kernel.org,
Akinobu Mita <akinobu.mita@gmail.com>,
Andi Kleen <ak@linux.intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Christopher Li <sparse@chrisli.org>,
David Daney <david.daney@cavium.com>,
David Howells <dhowells@redhat.com>,
David Rientjes <rientjes@google.com>,
David Woodhouse <David.Woodhouse@intel.com>,
Don Zickus <dzickus@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v6 4/25] compiler-gcc{3,4}.h: Use GCC_VERSION macro
Date: Mon, 01 Oct 2012 15:43:31 -0500 [thread overview]
Message-ID: <506A0073.9090605@att.net> (raw)
In-Reply-To: <20121001203224.GB8478@jtriplet-mobl1>
On 10/01/2012 03:32 PM, Josh Triplett wrote:
> On Mon, Oct 01, 2012 at 12:39:44PM -0700, Andrew Morton wrote:
>> Is this correct (and clear)? I'd expect
>>
>> #if GCC_VERSION > 40000
> GCC_VERSION >= 40100, actually; __GNUC_MINOR__ > 0 implies
> __GNUC_MINOR__ >= 1, whereas the version you wrote would accept 4.0.1.
>
> - Josh Triplett
Yeah, and now I have two threads for the same set of patches, sorry. :(
Daniel
next prev parent reply other threads:[~2012-10-01 20:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 1:54 [PATCH v6 0/25] Generic Red-Black Trees Daniel Santos
2012-09-28 1:54 ` [PATCH v6 1/25] compiler-gcc4.h: Correct verion check for __compiletime_error Daniel Santos
2012-09-28 1:54 ` [PATCH v6 2/25] compiler-gcc4.h: Reorder macros based upon gcc ver Daniel Santos
2012-09-28 1:54 ` [PATCH v6 3/25] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro Daniel Santos
2012-09-28 1:54 ` [PATCH v6 4/25] compiler-gcc{3,4}.h: Use " Daniel Santos
2012-10-01 19:39 ` Andrew Morton
2012-10-01 20:32 ` Josh Triplett
2012-10-01 20:43 ` Daniel Santos [this message]
2012-09-28 1:54 ` [PATCH v6 5/25] compiler{,-gcc4}.h: Remove duplicate macros Daniel Santos
2012-09-28 1:54 ` [PATCH v6 6/25] bug.h: Replace __linktime_error with __compiletime_error Daniel Santos
2012-09-28 1:54 ` [PATCH v6 7/25] compiler{,-gcc4}.h: Introduce __flatten function attribute Daniel Santos
2012-10-01 19:43 ` [PATCH v6 0/25] Generic Red-Black Trees Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506A0073.9090605@att.net \
--to=danielfsantos@att.net \
--cc=David.Woodhouse@intel.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.santos@pobox.com \
--cc=david.daney@cavium.com \
--cc=dhowells@redhat.com \
--cc=dzickus@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=rientjes@google.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).