[BUG report] sparse warnings about "__ksymtab_*" symbols

[BUG report] sparse warnings about "__ksymtab_*" symbols

[Wanlong Gao]

Hi folks,

After following kernel commit[1](find through bisect), We can see many sparse warnings like:
"
/git/linux/kernel/time/timekeeping.c:229:1: warning: symbol '__ksymtab_pvclock_gtod_register_notifier' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:246:1: warning: symbol '__ksymtab_pvclock_gtod_unregister_notifier' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:323:1: warning: symbol '__ksymtab___getnstimeofday' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:335:1: warning: symbol '__ksymtab_getnstimeofday' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:357:1: warning: symbol '__ksymtab_ktime_get' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:388:1: warning: symbol '__ksymtab_ktime_get_ts' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:417:1: warning: symbol '__ksymtab_timekeeping_clocktai' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:432:1: warning: symbol '__ksymtab_ktime_get_clocktai' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:486:1: warning: symbol '__ksymtab_do_gettimeofday' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:526:1: warning: symbol '__ksymtab_do_settimeofday' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:570:1: warning: symbol '__ksymtab_timekeeping_inject_offset' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:689:1: warning: symbol '__ksymtab_ktime_get_real' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:712:1: warning: symbol '__ksymtab_getrawmonotonic' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:1467:1: warning: symbol '__ksymtab_getboottime' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:1500:1: warning: symbol '__ksymtab_get_monotonic_boottime' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:1517:1: warning: symbol '__ksymtab_ktime_get_boottime' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:1529:1: warning: symbol '__ksymtab_monotonic_to_bootbased' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:1537:1: warning: symbol '__ksymtab_get_seconds' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:1560:1: warning: symbol '__ksymtab_current_kernel_time' was not declared. Should it be static?
/git/linux/kernel/time/timekeeping.c:1662:1: warning: symbol '__ksymtab_ktime_get_monotonic_offset' was not declared. Should it be static?
"

Any thoughts?


Thanks,
Wanlong Gao



[1]
commit e0f244c63fc9d192dfd399cc2677bbdca61994b1
Author: Andi Kleen <ak@linux.intel.com>
Date:   Wed Oct 23 10:57:58 2013 +1030

    asmlinkage, module: Make ksymtab and kcrctab symbols and __this_module __visible
    
    Make the ksymtab symbols for EXPORT_SYMBOL visible.
    This prevents the LTO compiler from adding a .NUMBER prefix,
    which avoids various problems in later export processing.
    
    Cc: rusty@rustcorp.com.au
    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Re: [BUG report] sparse warnings about "__ksymtab_*" symbols

[Wei Yongjun]

ref to http://www.spinics.net/lists/linux-sparse/msg03297.html

On 11/26/2013 09:51 AM, Wanlong Gao wrote:
> Hi folks,
>
> After following kernel commit[1](find through bisect), We can see many sparse warnings like:
> "
> /git/linux/kernel/time/timekeeping.c:229:1: warning: symbol '__ksymtab_pvclock_gtod_register_notifier' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:246:1: warning: symbol '__ksymtab_pvclock_gtod_unregister_notifier' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:323:1: warning: symbol '__ksymtab___getnstimeofday' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:335:1: warning: symbol '__ksymtab_getnstimeofday' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:357:1: warning: symbol '__ksymtab_ktime_get' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:388:1: warning: symbol '__ksymtab_ktime_get_ts' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:417:1: warning: symbol '__ksymtab_timekeeping_clocktai' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:432:1: warning: symbol '__ksymtab_ktime_get_clocktai' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:486:1: warning: symbol '__ksymtab_do_gettimeofday' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:526:1: warning: symbol '__ksymtab_do_settimeofday' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:570:1: warning: symbol '__ksymtab_timekeeping_inject_offset' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:689:1: warning: symbol '__ksymtab_ktime_get_real' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:712:1: warning: symbol '__ksymtab_getrawmonotonic' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1467:1: warning: symbol '__ksymtab_getboottime' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1500:1: warning: symbol '__ksymtab_get_monotonic_boottime' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1517:1: warning: symbol '__ksymtab_ktime_get_boottime' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1529:1: warning: symbol '__ksymtab_monotonic_to_bootbased' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1537:1: warning: symbol '__ksymtab_get_seconds' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1560:1: warning: symbol '__ksymtab_current_kernel_time' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1662:1: warning: symbol '__ksymtab_ktime_get_monotonic_offset' was not declared. Should it be static?
> "
>
> Any thoughts?
>
>
> Thanks,
> Wanlong Gao
>
>
>
> [1]
> commit e0f244c63fc9d192dfd399cc2677bbdca61994b1
> Author: Andi Kleen <ak@linux.intel.com>
> Date:   Wed Oct 23 10:57:58 2013 +1030
>
>     asmlinkage, module: Make ksymtab and kcrctab symbols and __this_module __visible
>     
>     Make the ksymtab symbols for EXPORT_SYMBOL visible.
>     This prevents the LTO compiler from adding a .NUMBER prefix,
>     which avoids various problems in later export processing.
>     
>     Cc: rusty@rustcorp.com.au
>     Signed-off-by: Andi Kleen <ak@linux.intel.com>
>     Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>