From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Christopher Li <sparse@chrisli.org>, John Keeping <john@keeping.me.uk>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] evaluate: split out implementation of compatible_assignment_types
Date: Tue, 01 Apr 2014 15:31:11 +0100 [thread overview]
Message-ID: <533ACDAF.6050408@ramsay1.demon.co.uk> (raw)
In-Reply-To: <CANeU7Qm5pHTZCSk83ToxXqDPw4RfEaOTnE6YntQa+KEYVZUi0w@mail.gmail.com>
On 01/04/14 08:46, Christopher Li wrote:
> On Sun, Mar 9, 2014 at 4:32 AM, John Keeping <john@keeping.me.uk> wrote:
>> This will allow us to reuse the logic when processing a transparent
>> union by checking each member in turn without printing a warning unless
>> none of the members match.
>
> Both patches applied.
>
> Chris
I 'tested' these patches (on Linux), by running sparse over the git.git
sources, as soon as they were posted. They worked beautifully. (git.git
on Linux (32-bit) only has a single sparse warning now - yay! :)
I forgot to report that here, since I had intended to test the patches
on Cygwin and (my version of sparse) on MinGW first, but I didn't get
around to it ... sorry! (Hmm, I may have time tonight ...)
ATB,
Ramsay Jones
prev parent reply other threads:[~2014-04-01 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 11:32 [PATCH v2 1/2] evaluate: split out implementation of compatible_assignment_types John Keeping
2014-03-09 11:32 ` [PATCH v2 2/2] Support GCC's transparent unions John Keeping
2014-04-01 7:46 ` [PATCH v2 1/2] evaluate: split out implementation of compatible_assignment_types Christopher Li
2014-04-01 14:31 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533ACDAF.6050408@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=john@keeping.me.uk \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).