From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH] parse: support c99 [static ...] in abstract array declarators
Date: Wed, 16 Apr 2014 20:50:23 -0700 [thread overview]
Message-ID: <534F4F7F.5020506@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140417001234.GA18426@leaf>
On 04/16/2014 05:12 PM, Josh Triplett wrote:
> On Tue, Apr 15, 2014 at 04:08:57PM -0700, Cody P Schafer wrote:
>> Makes sparse a little more accepting than the standard: we accept any
>> number of ["static", "restrict"] repeated in any order, while the n1570
>> specifies (in 6.7.6.2.3) that either type-qualifiers (ie: "restrict")
>> come first and are followed by "static" or the opposite ("static" then
>> type-qualifiers).
>>
>> Also add a test.
>>
>> Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
>
> What's the rationale for this? Why should sparse accept more than the
> standard allows? What real-world code do you have that requires this?
>
> And would it be worth adding a warning for this non-standards-compliant
> code, even if that warning isn't on by default?
I could have sparse be just as strict as the standard, it just was just
(much) simpler to make it liberal in what it accepts. If you're fine
with some more verbose code, I'll put together something that is stricter.
next prev parent reply other threads:[~2014-04-17 3:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 23:08 [PATCH] parse: support c99 [static ...] in abstract array declarators Cody P Schafer
2014-04-17 0:12 ` Josh Triplett
2014-04-17 3:50 ` Cody P Schafer [this message]
2014-04-17 5:09 ` Josh Triplett
2014-04-17 6:50 ` Christopher Li
2014-04-18 5:52 ` Christopher Li
2014-04-21 16:43 ` Cody P Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534F4F7F.5020506@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=josh@joshtriplett.org \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).