From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Christopher Li <sparse@chrisli.org>
Cc: Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 06/10] don't run sparse{c,i} tests when sparse-llvm is disabled
Date: Thu, 02 Oct 2014 11:31:48 +0100 [thread overview]
Message-ID: <542D2994.7020304@ramsay1.demon.co.uk> (raw)
In-Reply-To: <CANeU7QnXWFad9Re0MtGkei6F6ZnUOH96et5_7aJQommFp2dLwQ@mail.gmail.com>
On 02/10/14 04:44, Christopher Li wrote:
> On Tue, Sep 30, 2014 at 11:26 AM, Christopher Li <sparse@chrisli.org> wrote:
>> I am thinking some thing in the test-suite like:
>>
>> set_deps sparsec sparse-llvm
>> set_deps sparsei sparse-llvm
>>
>> ...
>> get_deps `basename cmd`
>> dep_cmd=$last_result
>
> Actually, I try that, it is a little bit too complicated.
>
> Your first approach is fine.
>
> I end up using your V1 patch, with a small change to do exact match rather than
> a wild cast. The wild cast has danger that match a sub word of the command.
> e.g. if you try to disable command "sp", it will disable "sparse" as well.
Ah yes, good catch!
ATB,
Ramsay Jones
prev parent reply other threads:[~2014-10-02 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 18:38 [PATCH 06/10] don't run sparse{c,i} tests when sparse-llvm is disabled Ramsay Jones
2014-09-27 4:29 ` Christopher Li
2014-09-27 13:37 ` Ramsay Jones
2014-09-30 3:26 ` Christopher Li
2014-10-02 3:44 ` Christopher Li
2014-10-02 10:31 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542D2994.7020304@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).