Re: [PATCH 3/3 V3] Add Wall_off switch to disable errors and warnings

[Tony Camuso <tcamuso@redhat.com>]

On 08/01/2015 08:59 AM, Sam Ravnborg wrote:
>> diff --git a/parse.c b/parse.c
>> index 02275d8..d70dffb 100644
>> --- a/parse.c
>> +++ b/parse.c
>> @@ -2746,6 +2746,10 @@ struct token *external_declaration(struct token *token, struct symbol_list **lis
>>
>>   	/* Just a type declaration? */
>>   	if (!ident) {
>> +
>> +		if (Wall_off)
>> +			return token->next;
>> +
>>   		warning(token->pos, "missing identifier in declaration");
>>   		return expect(token, ';', "at the end of type declaration");
>
> This is on the wrong level.
> You need to silence sparse in the spare_error function.
>
> Not on the level where you do the expect() - otherwise you would
> have to sprinkle "if (Wall_off)" checks everywhere.
>
> This was also a problem in v1 of the patch.
>
> 	Sam
>

Thanks, Sam. Rework in progress ...