From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Camuso Subject: Re: [PATCH 3/3] Add NOWARN and NOERR compile conditions Date: Sun, 2 Aug 2015 09:42:00 -0400 Message-ID: <55BE1E28.3040605@redhat.com> References: <1438216001-8862-1-git-send-email-tcamuso@redhat.com> <1438216001-8862-4-git-send-email-tcamuso@redhat.com> <20150730025502.GA1692@x> <55BA0E4E.7000508@redhat.com> <55BCA8D2.1040808@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50859 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbbHBNmC (ORCPT ); Sun, 2 Aug 2015 09:42:02 -0400 In-Reply-To: Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Christopher Li Cc: Josh Triplett , Linux-Sparse On 08/01/2015 02:45 PM, Christopher Li wrote: > On Sat, Aug 1, 2015 at 4:09 AM, Tony Camuso wrote: >> >> I've since submitted a runtime patch (3/3 V3) with a switch as a >> response to this patch, but it basically does the same thing here. >> >> Consider the case where the source contains something like this... >> >> struct foo { >> union { >> int number; >> int *pointer; >> }; >> }; >> >> There being no ident for the union within the struct, we get the warning, >> "missing identifier in declaration" etc. >> > > I can't reproduce the warning with the chrisl repo master branch. > > That being said, if there is indeed a bug in sparse, it should be a > separate patch. It changes the parsing behavior. > > Thanks > > Chris > I'll isolate exactly where the report is coming from, but it is tripping over this in parse.c warning(token->pos, "missing identifier in declaration"); return expect(token, ';', "at the end of type declaration");