From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B5AFC4363A for ; Mon, 5 Oct 2020 09:04:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 154F420781 for ; Mon, 5 Oct 2020 09:04:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725937AbgJEJEr (ORCPT ); Mon, 5 Oct 2020 05:04:47 -0400 Received: from imap2.colo.codethink.co.uk ([78.40.148.184]:46970 "EHLO imap2.colo.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgJEJEr (ORCPT ); Mon, 5 Oct 2020 05:04:47 -0400 Received: from cpc98990-stkp12-2-0-cust216.10-2.cable.virginm.net ([86.26.12.217] helo=[192.168.0.10]) by imap2.colo.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1kPMQG-00077z-2y; Mon, 05 Oct 2020 10:04:44 +0100 Subject: Re: [PATCH 0/8] format check tweaks To: Luc Van Oostenryck , linux-sparse@vger.kernel.org References: <20201005020002.1108-1-luc.vanoostenryck@gmail.com> From: Ben Dooks Organization: Codethink Limited. Message-ID: <58d771f9-7560-f682-3173-78dea0f83711@codethink.co.uk> Date: Mon, 5 Oct 2020 10:04:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201005020002.1108-1-luc.vanoostenryck@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org On 05/10/2020 02:59, Luc Van Oostenryck wrote: > Ben, these are small changes I think should be applied with > your series, on top of the patches I send yesterday. > I've pushed everything at: > git://github.com/lucvoo/sparse-dev.git format-check > If you're fine with these, I can squeeze them with the series. > > There are also a few tests I don't agree with: > const void *ptr = ... > printf("%s", ptr); > These tests silently accept this, but they should warn. > But this can be fixed at a later step. ok, thanks. I'm going to try and work out the best way to deal with the kernel extra funsies. I have a few ideas but yet to make a coherent document about them. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html