Re: Re: [PATCH 15/16] deal with enum members without excessive PITA

["Christopher Li" <sparse@chrisli.org>]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

On Dec 14, 2007 4:09 AM, Thomas Schmid <Thomas.Schmid@br-automation.com> wrote:
> How about the idea, looping over the syms within global_scope?

I think that will work too.

> > > It should be trivial make a patch to add members to the parent
> > symbol->symbol_list though.
> Would you possibly?

Can you try the attached patch?

Chris

[-- Attachment #2: enum-members --]
[-- Type: application/octet-stream, Size: 1171 bytes --]

Add enum member list to the parent

Signed-Off-By: Christopher Li <sparse@chrisli.org>

Index: sparse/parse.c
===================================================================
--- sparse.orig/parse.c	2007-12-14 12:33:05.000000000 -0800
+++ sparse/parse.c	2007-12-14 12:42:39.000000000 -0800
@@ -651,7 +651,6 @@ static struct token *parse_enum_declarat
 	unsigned long long lastval = 0;
 	struct symbol *ctype = NULL, *base_type = NULL;
 	Num upper = {-1, 0}, lower = {1, 0};
-	struct symbol_list *entries = NULL;
 
 	parent->examined = 1;
 	parent->ctype.base_type = &int_ctype;
@@ -687,7 +686,7 @@ static struct token *parse_enum_declarat
 		sym->initializer = expr;
 		sym->enum_member = 1;
 		sym->ctype.base_type = parent;
-		add_ptr_list(&entries, sym);
+		add_ptr_list(&parent->symbol_list, sym);
 
 		if (base_type != &bad_ctype) {
 			if (ctype->type == SYM_NODE)
@@ -763,8 +762,7 @@ static struct token *parse_enum_declarat
 	parent->ctype.modifiers |= (base_type->ctype.modifiers & MOD_UNSIGNED);
 	parent->examined = 0;
 
-	cast_enum_list(entries, base_type);
-	free_ptr_list(&entries);
+	cast_enum_list(parent->symbol_list, base_type);
 
 	return token;
 }