for (int i = expr; ....)

for (int i = expr; ....)

[Pierre Habouzit]

[-- Attachment #1: Type: text/plain, Size: 761 bytes --]

Sparse doesn't support the C99 construct `for (int i = expr; ....)` properly.
for example, the following C code:

    #include <stdlib.h>

    int main(void)
    {
        for (int i = atoi("12"); i < 10; i++);
        return 0;
    }

make sparse spit:

    $ sparse -Wall test.c
    test.c:5:22: warning: call with no type!

In fact sparse doesn't support 'expr' to be a complex enough expression
(expressions that can be folded work, but not any other afaict).

I assume something has to be done in parser.c, but I'm not really sure it's the
sole place…


-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: for (int i = expr; ....)

[Chris Li]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

On Thu, Feb 21, 2008 at 7:05 AM, Pierre Habouzit
<pierre.habouzit@m4x.org> wrote:
> Sparse doesn't support the C99 construct `for (int i = expr; ....)` properly.
>  for example, the following C code:
>
>     #include <stdlib.h>
>
>     int main(void)
>     {
>         for (int i = atoi("12"); i < 10; i++);
>         return 0;
>     }
>
>  make sparse spit:
>
>     $ sparse -Wall test.c
>     test.c:5:22: warning: call with no type!
>
>  In fact sparse doesn't support 'expr' to be a complex enough expression
>  (expressions that can be folded work, but not any other afaict).

Nah, sparse supports expression in initializer all right.
It just need to evaluate them to give it the correct ctype.

Please try the this one line patch I attached.

Chris

[-- Attachment #2: init-notype --]
[-- Type: application/octet-stream, Size: 723 bytes --]

evaluate iterator symbols

evaluate.c forgets to evaluate iterator_syms, which
might have some expression in initializer.

Signed-Off-By: Christopher Li <sparse@chrisli.org>

Index: sparse/evaluate.c
===================================================================
--- sparse.orig/evaluate.c	2008-02-13 09:25:21.000000000 -0800
+++ sparse/evaluate.c	2008-02-22 10:07:10.000000000 -0800
@@ -3093,6 +3093,7 @@ static void evaluate_if_statement(struct
 
 static void evaluate_iterator(struct statement *stmt)
 {
+	evaluate_symbol_list(stmt->iterator_syms);
 	evaluate_conditional(stmt->iterator_pre_condition, 1);
 	evaluate_conditional(stmt->iterator_post_condition,1);
 	evaluate_statement(stmt->iterator_pre_statement);

Re: for (int i = expr; ....)

[Pierre Habouzit]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

On Fri, Feb 22, 2008 at 08:26:30PM +0000, Chris Li wrote:
> On Thu, Feb 21, 2008 at 7:05 AM, Pierre Habouzit
> <pierre.habouzit@m4x.org> wrote:
> > Sparse doesn't support the C99 construct `for (int i = expr; ....)` properly.
> >  for example, the following C code:
> >
> >     #include <stdlib.h>
> >
> >     int main(void)
> >     {
> >         for (int i = atoi("12"); i < 10; i++);
> >         return 0;
> >     }
> >
> >  make sparse spit:
> >
> >     $ sparse -Wall test.c
> >     test.c:5:22: warning: call with no type!
> >
> >  In fact sparse doesn't support 'expr' to be a complex enough expression
> >  (expressions that can be folded work, but not any other afaict).
> 
> Nah, sparse supports expression in initializer all right.
> It just need to evaluate them to give it the correct ctype.
> 
> Please try the this one line patch I attached.

  Works for me, thanks.


-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]