Re: [PATCH 03/15] Add type information to struct instruction.

["Christopher Li" <sparse@chrisli.org>]

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

On Tue, Dec 23, 2008 at 3:23 AM, David Given <dg@cowlark.com> wrote:
> I'm sure there's a better way of doing it, but I just couldn't find one!
> So if you can think of any way to clean all this up I'd be delighted.
> The underlying issue, BTW, is that OP_LOAD doesn't carry enough
> information in its arguments to determine the type of the instruction.

OK, if it is just for OP_LOAD. Will this attached patch solve your problem?

Instead of adding type to every instruction. It just add that for the OP_LOAD
instruction in insn->orig_type. If that works for you. I am very glad to reclaim
the space back on instruction structure.

> Incidentally, speaking of distinguishing arguments, one of the issues I
> have with Clue is that sparse can't distinguish between parameters of
> the different types but the same size in some situations --- e.g.:
>
> extern void foo(float i);
> ...
> foo(5);
>
> ...will call foo() with an *integer* parameter rather than a float one.
> This is preventing me doing certain optimisations (like being able to
> store ints in ints rather than doubles!). Is this related?

I think sparse should do the proper cast for you when you call
the function call. If it does not, that is a bug and we can fix it.

Please let me know if you can use the patch.

Chris

[-- Attachment #2: load_type --]
[-- Type: application/octet-stream, Size: 1133 bytes --]

Make type information only for OP_LOAD

Index: sparse/linearize.c
===================================================================
--- sparse.orig/linearize.c
+++ sparse/linearize.c
@@ -55,9 +55,7 @@ static inline int type_size(struct symbo
 
 static struct instruction *alloc_typed_instruction(int opcode, struct symbol *type)
 {
-	struct instruction *insn = alloc_instruction(opcode, type_size(type));
-	insn->type = type;
-	return insn;
+	return alloc_instruction(opcode, type_size(type));
 }
 
 static struct entrypoint *alloc_entrypoint(void)
@@ -915,6 +913,7 @@ static pseudo_t add_load(struct entrypoi
 
 	insn->target = new;
 	insn->offset = ad->offset;
+	insn->orig_type = ad->source_type;
 	use_pseudo(insn, ad->address, &insn->src);
 	add_one_insn(ep, insn);
 	return new;
Index: sparse/linearize.h
===================================================================
--- sparse.orig/linearize.h
+++ sparse/linearize.h
@@ -71,7 +71,6 @@ struct instruction {
 		 size:24;
 	struct basic_block *bb;
 	struct position pos;
-	struct symbol *type;
 	union {
 		pseudo_t target;
 		pseudo_t cond;		/* for branch and switch */