From: Christopher Li <sparse@chrisli.org>
To: Samuel Bronson <naesten@gmail.com>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH-v2 2/4] Replace SYM_ and MOD_ #defines with enums in symbol.h.
Date: Tue, 2 Jun 2009 13:44:20 -0700 [thread overview]
Message-ID: <70318cbf0906021344w2adcf585g7d7adcd320d66fa9@mail.gmail.com> (raw)
In-Reply-To: <1243881445-30069-2-git-send-email-naesten@gmail.com>
On Mon, Jun 1, 2009 at 11:37 AM, Samuel Bronson <naesten@gmail.com> wrote:
> Adjust the associated fields to match. While we're here, change
> some nearby bitfields from "char" to "int" so GDB doesn't bother
> showing character literals for them.
> +enum modifier {
> + MOD_AUTO = 1 << 0,
The patch does not apply to my tree. The modifier is definitely not
an enum because we apply bit operation to it.
Changing bitfield from "char" to "int" has risk of making the symbol
struct bigger. We don't want that because symbol is a very common
structure for sparse.
Chris
next prev parent reply other threads:[~2009-06-02 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1243881445-30069-1-git-send-email-naesten@gmail.com>
2009-06-01 18:37 ` [PATCH-v2 2/4] Replace SYM_ and MOD_ #defines with enums in symbol.h Samuel Bronson
[not found] ` <1243881445-30069-3-git-send-email-naesten@gmail.com>
2009-06-01 18:37 ` [PATCH 4/4] Have Makefile import config.mak if it exists Samuel Bronson
2009-06-02 20:30 ` Christopher Li
2009-06-03 0:37 ` Samuel Bronson
2009-06-02 20:44 ` Christopher Li [this message]
2009-06-03 3:43 ` [PATCH-v2 2/4] Replace SYM_ and MOD_ #defines with enums in symbol.h Samuel Bronson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70318cbf0906021344w2adcf585g7d7adcd320d66fa9@mail.gmail.com \
--to=sparse@chrisli.org \
--cc=linux-sparse@vger.kernel.org \
--cc=naesten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).