linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christopher Li <sparse@chrisli.org>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 5/5] Add a --version option to sparse
Date: Sat, 25 Jul 2009 12:34:59 -0700	[thread overview]
Message-ID: <70318cbf0907251234o6028d0adh8a470f40f373578@mail.gmail.com> (raw)
In-Reply-To: <4A6A0BF2.7080509@ramsay1.demon.co.uk>

On Fri, Jul 24, 2009 at 12:30 PM, Ramsay
Jones<ramsay@ramsay1.demon.co.uk> wrote:
> $ git checkout master
> $ git describe
> 0.4.1-99-g37f041a

If works well if you are following the official branch. If you are working
on your own, you might have some private tag. Then that will mess up
the "git describe". My tag might not even look like a version number.

So for version numbers, I still prefer the dot and numbers. We can
follow what Linux kernel do for version strings.

> My intent with this patch was to provide sparse (the program) with a
> version number; *not* the sparse library, which is a separate issue.
> (If a library version number is implemented, then the sparse program
> version number *could* be the same number, of course). I did not
> consider the other example programs built with sparse, but I suppose
> they could all share the same version number if necessary.

In my mind, they share the same version number. Individual version
the program inside sparse package is kind of messy. I don't see
a need for that in the near future yet.

> However, you would not want sparse (the library) to force *all*
> applications built with the library to handle the --version option
> by printing the sparse (the program) version string and exiting!

That is what YOUR current patch do, no?

>
> So, the library should just set a version_option seen flag and let
> the application process this flag itself.

That will force every program to process the version itself, doing more
or less the same thing.

Let's say I don't need separate version inside sparse package.
Does "-v" printing out sparse version string in side lib.c satisfy
your need already? In that case, I don't see the need for a separate
"--version".

Chris

  reply	other threads:[~2009-07-25 19:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-18 21:06 [PATCH 5/5] Add a --version option to sparse Ramsay Jones
2009-07-22  0:57 ` Christopher Li
2009-07-24 19:30   ` Ramsay Jones
2009-07-25 19:34     ` Christopher Li [this message]
2009-07-28 17:46       ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70318cbf0907251234o6028d0adh8a470f40f373578@mail.gmail.com \
    --to=sparse@chrisli.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).