From: Christopher Li <sparse@chrisli.org>
To: Hannes Eder <hannes@hanneseder.net>
Cc: Al Viro <viro@ftp.linux.org.uk>, linux-sparse@vger.kernel.org
Subject: Re: [PATCH] test-suite: integrate unhandled proprocessor tests
Date: Mon, 27 Jul 2009 14:04:00 -0700 [thread overview]
Message-ID: <70318cbf0907271404i34dac921ge2b3f4d4dcc7c596@mail.gmail.com> (raw)
In-Reply-To: <20090727181048.18280.38099.stgit@f10box.hanneseder.net>
On Mon, Jul 27, 2009 at 11:13 AM, Hannes Eder<hannes@hanneseder.net> wrote:
> Instrument validate/preprocessor/preproprocessor*.c to be integrated
> into the test-suite where missing and add an additional test case.
Thanks, applied.
> Ok there is a difference in the number of empty lines, who cares, but
> spares outputs a "," and cpp does not.
>
> Could somebody with more insight comment on this? Al? :)
>
> Meanwhile I marked this test as "check-known-to-fail".
Currently sparse did not handle ##__VA_ARGS__ the same ways
as gcc. Take a look at parse_expansion(). It marks TOKEN_GNU_KLUDGE
only if it saw "," right before "##__VA_ARGS__". So ",##x##__VA_ARGS__"
will not get generate TOKEN_GNU_KLUDE.
The fix is that ##__VA_ARGS__ should kick in *after* the argument
list has been expanded. It literally delete the previous "," if __VA_ARGS__ is
empty.
Am I missing any thing, AI?
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
parent reply other threads:[~2009-07-27 21:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20090727181048.18280.38099.stgit@f10box.hanneseder.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70318cbf0907271404i34dac921ge2b3f4d4dcc7c596@mail.gmail.com \
--to=sparse@chrisli.org \
--cc=hannes@hanneseder.net \
--cc=linux-sparse@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).