From: Christopher Li <sparse@chrisli.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "Robert P. J. Day" <rpjday@crashcourse.ca>,
sparse <linux-sparse@vger.kernel.org>
Subject: Re: Detect unused header files?
Date: Tue, 28 Jul 2009 14:38:06 -0700 [thread overview]
Message-ID: <70318cbf0907281438i876e21fja037aed7169aa8bf@mail.gmail.com> (raw)
In-Reply-To: <20090728210404.GA21187@merkur.ravnborg.org>
On Tue, Jul 28, 2009 at 2:04 PM, Sam Ravnborg<sam@ravnborg.org> wrote:
>
> Agreed on this one.
>
> So we should add some intelligence when we 'fix' these warnings.
> This is sometimes causing us troubles.
>
> I need to see the results before I can judge if this will
> be a big issue.
I don't know. It is not trivial change and lookup_symbol is at the hot path.
Most of the header file does not include unused headers. So I guess amount
the warnings, over 50% will be false positives. We will see.
> The first challenge will anyway to make all the header files self contained.
It is much easier than find out what is not needed.
Can you make a list of all the header files. Then using gcc -c to compile it?
Not self contained header file will failed on compile. Assume you give the right
kernel flags and header file include path.
Chris
next prev parent reply other threads:[~2009-07-28 21:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 18:18 Detect unused header files? Sam Ravnborg
2009-07-28 20:36 ` Christopher Li
2009-07-28 20:36 ` Robert P. J. Day
2009-07-28 20:49 ` Christopher Li
2009-07-28 21:04 ` Sam Ravnborg
2009-07-28 21:38 ` Christopher Li [this message]
2009-07-30 10:55 ` Christopher Li
2009-07-30 11:12 ` Derek M Jones
2009-07-30 20:36 ` Sam Ravnborg
2009-08-04 21:49 ` Christopher Li
2009-08-05 6:12 ` Sam Ravnborg
2009-08-06 11:14 ` Marko Kreen
2009-08-06 11:17 ` Robert P. J. Day
2009-08-06 12:16 ` Kamil Dudka
2009-08-06 12:15 ` Robert P. J. Day
2009-08-06 13:01 ` Kamil Dudka
2009-08-06 13:26 ` Michael Stefaniuc
2009-08-06 14:09 ` Robert P. J. Day
2009-08-06 17:39 ` Christopher Li
2009-07-28 20:58 ` Sam Ravnborg
2009-07-28 21:21 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70318cbf0907281438i876e21fja037aed7169aa8bf@mail.gmail.com \
--to=sparse@chrisli.org \
--cc=linux-sparse@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).