Re: [PATCH] linearize.h: sanitize header

[Christopher Li <sparse@chrisli.org>]

On Thu, Aug 6, 2009 at 4:09 AM, Hannes Eder<hannes@hanneseder.net> wrote:
>> $ grep --color '[^_]false[^_]' *.c
>
> $ grep --color '\bfalse\b\|\btrue\b' *.c | wc -l
> 91
>
> some of them are just in comments, does not look to scary to me.  If
> others agree that its a good idea to rename them, I can do it if you
> don't want to.

I would just apply the change to the header file and related variables.
The linearize.h is consider an API header file for other sparse application
to use. So we'd better not assume too much on the sparse caller side.

I agree with Kamil that rename variable in linearize.c offer no real
benefits. I consider it more of a personal preference thing. And it is
internal to linearize.c. At this point renaming variable will mess up with
annotations. It is not good enough reason to do it just to make
the editor happy.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html