From: Christopher Li <sparse@chrisli.org>
To: Steven Rostedt <srostedt@redhat.com>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
Ingo Molnar <mingo@elte.hu>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sparse@vger.kernel.org,
Josh Triplett <josh@freedesktop.org>
Subject: Re: Warning from ring buffer code (Was: Re: linux-next: tip tree build warning)
Date: Mon, 14 Sep 2009 10:09:27 -0700 [thread overview]
Message-ID: <70318cbf0909141009v46581785m4c70edf31fcb79fa@mail.gmail.com> (raw)
In-Reply-To: <1252941416.2964.143.camel@localhost.localdomain>
On Mon, Sep 14, 2009 at 8:16 AM, Steven Rostedt <srostedt@redhat.com> wrote:
> static void func(int size_me) {
> char array[size_me];
>
> memcpy(array, "hello", size);
> };
>
> and sparse failed on it as well. Note, you need to have something call
> func, or sparse will ignore it.
Gcc allows variable size. Sparse expects the size of an array is constant.
For the kernel using variable array size is consider bad. Because the kernel
has very limited stack size. (8K if I remember correctly). Using dynamic array
is very easy to overflow the stack without realizing it.
It deserves a warning. I agree the warning message can use a better description
though.
Chris
next prev parent reply other threads:[~2009-09-14 17:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090804161640.70817ee6.sfr@canb.auug.org.au>
[not found] ` <1249403089.4634.139.camel@localhost.localdomain>
[not found] ` <20090912165300.9d257283.sfr@canb.auug.org.au>
[not found] ` <20090912073906.GA3972@elte.hu>
[not found] ` <1252753957.12217.10.camel@ht.satnam>
2009-09-14 15:16 ` Warning from ring buffer code (Was: Re: linux-next: tip tree build warning) Steven Rostedt
2009-09-14 17:09 ` Christopher Li [this message]
2009-09-14 18:17 ` Steven Rostedt
2009-09-14 18:23 ` Peter Zijlstra
2009-09-14 18:31 ` Steven Rostedt
2009-09-14 18:41 ` Frederic Weisbecker
2009-09-15 7:16 ` Peter Zijlstra
2009-09-15 9:01 ` Frédéric Weisbecker
2009-09-14 18:38 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70318cbf0909141009v46581785m4c70edf31fcb79fa@mail.gmail.com \
--to=sparse@chrisli.org \
--cc=hpa@zytor.com \
--cc=jaswinder@kernel.org \
--cc=josh@freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).