Compile errors with LLVM v17

Compile errors with LLVM v17

[Dan Carpenter]

I upgraded my Debian system and started getting compile errors with LLVM
version 17.  Apparently those APIs will need to be changed.
https://llvm.org/docs/OpaquePointers.html

regards,
dan carpenter

sparse-llvm.c: In function ‘get_sym_value’:
sparse-llvm.c:305:34: warning: implicit declaration of function ‘LLVMConstGEP’; did you mean ‘LLVMConstGEP2’? [-Wimplicit-function-declaration]
  305 |                         result = LLVMConstGEP(data, indices, ARRAY_SIZE(indices));
      |                                  ^~~~~~~~~~~~
      |                                  LLVMConstGEP2
sparse-llvm.c:305:32: warning: assignment to ‘LLVMValueRef’ {aka ‘struct LLVMOpaqueValue *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  305 |                         result = LLVMConstGEP(data, indices, ARRAY_SIZE(indices));
      |                                ^
sparse-llvm.c: In function ‘calc_gep’:
sparse-llvm.c:488:16: warning: implicit declaration of function ‘LLVMBuildInBoundsGEP’; did you mean ‘LLVMBuildInBoundsGEP2’? [-Wimplicit-function-declaration]
  488 |         addr = LLVMBuildInBoundsGEP(builder, base, &off, 1, name);
      |                ^~~~~~~~~~~~~~~~~~~~
      |                LLVMBuildInBoundsGEP2
sparse-llvm.c:488:14: warning: assignment to ‘LLVMValueRef’ {aka ‘struct LLVMOpaqueValue *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  488 |         addr = LLVMBuildInBoundsGEP(builder, base, &off, 1, name);
      |              ^
sparse-llvm.c: In function ‘output_op_load’:
sparse-llvm.c:714:18: warning: implicit declaration of function ‘LLVMBuildLoad’; did you mean ‘LLVMBuildLoad2’? [-Wimplicit-function-declaration]
  714 |         target = LLVMBuildLoad(fn->builder, addr, name);
      |                  ^~~~~~~~~~~~~
      |                  LLVMBuildLoad2
sparse-llvm.c:714:16: warning: assignment to ‘LLVMValueRef’ {aka ‘struct LLVMOpaqueValue *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  714 |         target = LLVMBuildLoad(fn->builder, addr, name);
      |                ^
sparse-llvm.c: In function ‘output_op_call’:
sparse-llvm.c:822:18: warning: implicit declaration of function ‘LLVMBuildCall’; did you mean ‘LLVMBuildCall2’? [-Wimplicit-function-declaration]
  822 |         target = LLVMBuildCall(fn->builder, func, args, n_arg, name);
      |                  ^~~~~~~~~~~~~
      |                  LLVMBuildCall2
sparse-llvm.c:822:16: warning: assignment to ‘LLVMValueRef’ {aka ‘struct LLVMOpaqueValue *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  822 |         target = LLVMBuildCall(fn->builder, func, args, n_arg, name);
      |                ^

Re: Compile errors with LLVM v17

[Ramsay Jones]

On 15/01/2024 10:32, Dan Carpenter wrote:
> I upgraded my Debian system and started getting compile errors with LLVM
> version 17.  Apparently those APIs will need to be changed.
> https://llvm.org/docs/OpaquePointers.html

Yep, I recently updated to LLVM version 14 and these APIs are shown
as deprecated (sparse-llvm is still built):

  $ make
  Makefile:170: Your system does not have sqlite3, disabling semind
  Makefile:192: Your system does not have gtk3/gtk2, disabling test-inspect
    CC      compile.o
    ...
    CC      sparse-llvm.o
  sparse-llvm.c: In function ‘get_sym_value’:
  sparse-llvm.c:305:25: warning: ‘LLVMConstGEP’ is deprecated [-Wdeprecated-declarations]
    305 |                         result = LLVMConstGEP(data, indices, ARRAY_SIZE(indices));
        |                         ^~~~~~
  In file included from /usr/lib/llvm-14/include/llvm-c/Core.h:18,
                   from sparse-llvm.c:6:
  /usr/lib/llvm-14/include/llvm-c/Core.h:2157:18: note: declared here
   2157 |     LLVMValueRef LLVMConstGEP(LLVMValueRef ConstantVal,
        |                  ^~~~~~~~~~~~
  /usr/lib/llvm-14/include/llvm-c/Deprecated.h:29:3: note: in definition of macro ‘LLVM_ATTRIBUTE_C_DEPRECATED’
     29 |   decl __attribute__((deprecated))
        |   ^~~~
  sparse-llvm.c: In function ‘calc_gep’:
  sparse-llvm.c:488:9: warning: ‘LLVMBuildInBoundsGEP’ is deprecated [-Wdeprecated-declarations]
    488 |         addr = LLVMBuildInBoundsGEP(builder, base, &off, 1, name);
        |         ^~~~
  In file included from /usr/lib/llvm-14/include/llvm-c/Core.h:18,
                   from sparse-llvm.c:6:
  /usr/lib/llvm-14/include/llvm-c/Core.h:3904:18: note: declared here
   3904 |     LLVMValueRef LLVMBuildInBoundsGEP(LLVMBuilderRef B, LLVMValueRef Pointer,
        |                  ^~~~~~~~~~~~~~~~~~~~
  /usr/lib/llvm-14/include/llvm-c/Deprecated.h:29:3: note: in definition of macro ‘LLVM_ATTRIBUTE_C_DEPRECATED’
     29 |   decl __attribute__((deprecated))
        |   ^~~~
  sparse-llvm.c: In function ‘output_op_load’:
  sparse-llvm.c:714:9: warning: ‘LLVMBuildLoad’ is deprecated [-Wdeprecated-declarations]
    714 |         target = LLVMBuildLoad(fn->builder, addr, name);
        |         ^~~~~~
  In file included from /usr/lib/llvm-14/include/llvm-c/Core.h:18,
                   from sparse-llvm.c:6:
  /usr/lib/llvm-14/include/llvm-c/Core.h:3892:18: note: declared here
   3892 |     LLVMValueRef LLVMBuildLoad(LLVMBuilderRef, LLVMValueRef PointerVal,
        |                  ^~~~~~~~~~~~~
  /usr/lib/llvm-14/include/llvm-c/Deprecated.h:29:3: note: in definition of macro ‘LLVM_ATTRIBUTE_C_DEPRECATED’
     29 |   decl __attribute__((deprecated))
        |   ^~~~
  sparse-llvm.c: In function ‘output_op_call’:
  sparse-llvm.c:822:9: warning: ‘LLVMBuildCall’ is deprecated [-Wdeprecated-declarations]
    822 |         target = LLVMBuildCall(fn->builder, func, args, n_arg, name);
        |         ^~~~~~
  In file included from /usr/lib/llvm-14/include/llvm-c/Core.h:18,
                   from sparse-llvm.c:6:
  /usr/lib/llvm-14/include/llvm-c/Core.h:3992:18: note: declared here
   3992 |     LLVMValueRef LLVMBuildCall(LLVMBuilderRef, LLVMValueRef Fn,
        |                  ^~~~~~~~~~~~~
  /usr/lib/llvm-14/include/llvm-c/Deprecated.h:29:3: note: in definition of macro ‘LLVM_ATTRIBUTE_C_DEPRECATED’
     29 |   decl __attribute__((deprecated))
        |   ^~~~
    LD      sparse-llvm
  $ 

Since I don't know anything about LLVM, I have been compiling like so:

  $ make LLVM_CONFIG=false

just to suppress the warnings (and it runs 42 less tests!). I have been
meaning to implement a make variable to suppress the sparse-llvm build
which can be placed into 'local.mk' ... but, well I never seem to have
enough round tuits! :)

ATB,
Ramsay Jones