From: "Farber, Eliav" <farbere@amazon.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: "luc.vanoostenryck@gmail.com" <luc.vanoostenryck@gmail.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"sj@kernel.org" <sj@kernel.org>,
"David.Laight@ACULAB.COM" <David.Laight@ACULAB.COM>,
"Jason@zx2c4.com" <Jason@zx2c4.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"linux-sparse@vger.kernel.org" <linux-sparse@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chocron, Jonathan" <jonnyc@amazon.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH 0/7 5.10.y] Cherry pick of minmax.h commits from 5.15.y
Date: Fri, 19 Sep 2025 10:41:09 +0000 [thread overview]
Message-ID: <98f086dbdc2d4a7c8586bdcb04571300@amazon.com> (raw)
In-Reply-To: <20250918220106.75a8191b@pumpkin>
> On Tue, 16 Sep 2025 21:22:52 +0000
> Eliav Farber <farbere@amazon.com> wrote:
>
> > This series backports seven commits from v5.15.y that update minmax.h
> > and related code:
> >
> > - ed6e37e30826 ("tracing: Define the is_signed_type() macro once")
> > - 998f03984e25 ("minmax: sanity check constant bounds when clamping")
> > - d470787b25e6 ("minmax: clamp more efficiently by avoiding extra
> > comparison")
> > - 1c2ee5bc9f11 ("minmax: fix header inclusions")
> > - d53b5d862acd ("minmax: allow min()/max()/clamp() if the arguments
> > have the same signedness.")
> > - 7ed91c5560df ("minmax: allow comparisons of 'int' against 'unsigned
> > char/short'")
> > - 22f7794ef5a3 ("minmax: relax check to allow comparison between
> > unsigned arguments and signed constants")
>
> I think you need to pick up the later changes (from Linus) as well.
> Without them nested min() and max() can generate very long lines from the pre-processor (tens of megabytes) that cause very slow and/or failing compilations on 32bit and other memory-limited systems.
>
> There are a few other changes needed at the same time.
> The current min() and max() can't be used in a few places because they aren't 'constant enough' with constant arguments.
I aligned minmax.h to include all changes in v6.17-rc6.
https://lore.kernel.org/stable/20250919101727.16152-1-farbere@amazon.com/T/#t
---
Regards, Eliav
prev parent reply other threads:[~2025-09-19 10:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 21:22 [PATCH 0/7 5.10.y] Cherry pick of minmax.h commits from 5.15.y Eliav Farber
2025-09-16 21:22 ` [PATCH 1/7 5.10.y] tracing: Define the is_signed_type() macro once Eliav Farber
2025-09-17 8:40 ` Greg KH
2025-09-17 10:37 ` Farber, Eliav
2025-09-21 17:30 ` Greg KH
2025-09-16 21:22 ` [PATCH 2/7 5.10.y] minmax: sanity check constant bounds when clamping Eliav Farber
2025-09-16 21:22 ` [PATCH 3/7 5.10.y] minmax: clamp more efficiently by avoiding extra comparison Eliav Farber
2025-09-16 21:22 ` [PATCH 4/7 5.10.y] minmax: fix header inclusions Eliav Farber
2025-09-18 21:01 ` [PATCH 0/7 5.10.y] Cherry pick of minmax.h commits from 5.15.y David Laight
2025-09-19 10:41 ` Farber, Eliav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98f086dbdc2d4a7c8586bdcb04571300@amazon.com \
--to=farbere@amazon.com \
--cc=David.Laight@ACULAB.COM \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bvanassche@acm.org \
--cc=david.laight.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonnyc@amazon.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sj@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).