Re: [PATCH 1/1] parser: add support for asm goto

[Christopher Li <sparse@chrisli.org>]

On Fri, Jun 18, 2010 at 1:29 AM, Jiri Slaby <jslaby@suse.cz> wrote:
> On 06/18/2010 10:21 AM, Jiri Slaby wrote:
>> Holy crap, in docco, there is nothing like that, but I checked gcc
>> parser sources to be sure, and there indeed is:
>>      asm type-qualifier[opt] ( asm-argument ) ;
>>      asm type-qualifier[opt] goto ( asm-goto-argument ) ;
>> So yes, asm volatile goto is valid. Would you take care of that?
>
> It is as easy as:
> diff --git a/parse.c b/parse.c
> index caf10b9..1d20658 100644
> --- a/parse.c
> +++ b/parse.c
> @@ -1915,7 +1915,8 @@ static struct token *parse_asm_statement(struct
> token *token, struct statement *
>        stmt->type = STMT_ASM;
>        if (match_idents(token, &__volatile___ident, &__volatile_ident,
> &volatile_ident, NULL)) {
>                token = token->next;
> -       } else if (match_idents(token, &goto_ident, NULL)) {
> +       }
> +       if (match_idents(token, &goto_ident, NULL)) {
>                is_goto = 1;
>                token = token->next;
>        }

Looks good to me.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html