From: Christopher Li <sparse@chrisli.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix 'already_tokenized()' performance problem
Date: Tue, 19 Apr 2011 14:52:47 -0700 [thread overview]
Message-ID: <BANLkTi=5mCuOWYZ_7Cav2jbLZ1DVUyyjag@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1104191108330.21972@i5.linux-foundation.org>
Very nice patch. Simple and clean.
Applied and pushed.
On Tue, Apr 19, 2011 at 11:12 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> This series of two trivial patches makes 'already_tokenized()' go away
> from profiles of a kernel build with C=2, shaving about 3-4% off the time
> for me.
I am suppressed that you can get 3-4% from just comparing the stream names.
Last time I try to optimized that nextchar() and nextchar_slow()
because Al complains
the tab character force the slow path, I haven't seen some thing like
1% difference.
So I leave it alone.
Thanks for the patch.
Chris
next prev parent reply other threads:[~2011-04-19 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 18:12 [PATCH 0/2] Fix 'already_tokenized()' performance problem Linus Torvalds
2011-04-19 18:17 ` [PATCH 1/2] Add new streams to a hash-list based on their names Linus Torvalds
2011-04-19 22:01 ` Christopher Li
2011-04-19 22:13 ` Linus Torvalds
2011-04-19 18:19 ` PATCH 2/2] Teach 'already_tokenized()' to use the stream name hash table Linus Torvalds
2011-04-19 21:52 ` Christopher Li [this message]
2011-04-19 22:09 ` [PATCH 0/2] Fix 'already_tokenized()' performance problem Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=5mCuOWYZ_7Cav2jbLZ1DVUyyjag@mail.gmail.com' \
--to=sparse@chrisli.org \
--cc=linux-sparse@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).