From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Li Subject: Re: [PATCH 0/2] Fix 'already_tokenized()' performance problem Date: Tue, 19 Apr 2011 14:52:47 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-vx0-f174.google.com ([209.85.220.174]:57056 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753569Ab1DSVwr (ORCPT ); Tue, 19 Apr 2011 17:52:47 -0400 Received: by vxi39 with SMTP id 39so118002vxi.19 for ; Tue, 19 Apr 2011 14:52:47 -0700 (PDT) In-Reply-To: Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Linus Torvalds Cc: linux-sparse@vger.kernel.org Very nice patch. Simple and clean. Applied and pushed. On Tue, Apr 19, 2011 at 11:12 AM, Linus Torvalds wrote: > > This series of two trivial patches makes 'already_tokenized()' go away > from profiles of a kernel build with C=2, shaving about 3-4% off the time > for me. I am suppressed that you can get 3-4% from just comparing the stream names. Last time I try to optimized that nextchar() and nextchar_slow() because Al complains the tab character force the slow path, I haven't seen some thing like 1% difference. So I leave it alone. Thanks for the patch. Chris