From d245709b074c8d07dba61b4a475148d4549e3697 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Sun, 30 Mar 2014 09:49:13 -0700 Subject: [PATCH 1/4] Add warning about duplicate initializers Noticed this while looking at an independent bug reported by Hans Verkuil. Signed-off-by: Linus Torvalds --- evaluate.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/evaluate.c b/evaluate.c index 66556150ddac..8a53b3e884e0 100644 --- a/evaluate.c +++ b/evaluate.c @@ -3043,10 +3043,18 @@ static void check_duplicates(struct symbol *sym) { int declared = 0; struct symbol *next = sym; + int initialized = sym->initializer != NULL; while ((next = next->same_symbol) != NULL) { const char *typediff; evaluate_symbol(next); + if (initialized && next->initializer) { + sparse_error(sym->pos, "symbol '%s' has multiple initializers (originally initialized at %s:%d)", + show_ident(sym->ident), + stream_name(next->pos.stream), next->pos.line); + /* Only warn once */ + initialized = 0; + } declared++; typediff = type_difference(&sym->ctype, &next->ctype, 0, 0); if (typediff) { -- 2.0.1.427.gc47372d