linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dibyendu Majumdar <mobile@majumdar.org.uk>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: sparse-llvm issue with handling of phisrc instruction
Date: Wed, 22 Mar 2017 19:46:48 +0000	[thread overview]
Message-ID: <CACXZuxeo24ABdTRgm_VR1UOvbGZ8-9rCpmDtLD8yqPNLeA1suw@mail.gmail.com> (raw)
In-Reply-To: <20170322192929.waqifaco6wtm7wue@macpro.local>

Hi Luc,

On 22 March 2017 at 19:29, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
>> >>>> I am trying to see if sparse-llvm can handle unsimplified IR output
>> >>>> from linearizer. I think there is a problem in how it handles phisrc.
>> >>>
>> >>> Does your non-simplified sparse IR contain the liveness information?
>> >>> I think those are needed for the handling of OP_PHI & OP_PHISOURCE
>> >>> in sparse-llvm.
>> >>>
>> >>
>> >> Probably not - I commented out everything in linearize_fn() from
>> >> simplify_symbol_usage() and downwards. Please tell me if this is
>> >> incorrect.
>> >
>> > As far as I understand, sparse-llvm needs track_pseudo_liveness().
>> >
>>
>> Tried that - it made no difference.
>
> I'm not sure liveness info has much sense without simplification,
> at least part of it.
>

You were right - I needed to retain following line:

track_pseudo_death(C, ep);

I mistakenly thought (going by name) that I had to call:

track_pseudo_liveness(C, ep);

Anyway it appears that this now populates the phi_users list so that
the code works correctly.

Thanks for your help.

Regards
Dibyendu

  reply	other threads:[~2017-03-22 19:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 16:46 sparse-llvm issue with handling of phisrc instruction Dibyendu Majumdar
2017-03-22 17:38 ` Luc Van Oostenryck
2017-03-22 18:05   ` Dibyendu Majumdar
2017-03-22 18:15     ` Luc Van Oostenryck
2017-03-22 18:17       ` Dibyendu Majumdar
2017-03-22 18:55         ` Dibyendu Majumdar
2017-03-22 20:42           ` Luc Van Oostenryck
2017-03-22 20:48             ` Dibyendu Majumdar
2017-03-22 21:38               ` Luc Van Oostenryck
2017-03-22 19:29         ` Luc Van Oostenryck
2017-03-22 19:46           ` Dibyendu Majumdar [this message]
2017-03-22 20:33             ` Dibyendu Majumdar
2017-03-22 20:46             ` Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACXZuxeo24ABdTRgm_VR1UOvbGZ8-9rCpmDtLD8yqPNLeA1suw@mail.gmail.com \
    --to=mobile@majumdar.org.uk \
    --cc=linux-sparse@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).