From: Dibyendu Majumdar <mobile@majumdar.org.uk>
To: Christopher Li <sparse@chrisli.org>
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: SSSA and some C pointer manipulation.
Date: Sat, 19 Aug 2017 12:57:43 +0100 [thread overview]
Message-ID: <CACXZuxf-yb5WODCDJ2cQxJ2_sKUwSeKwAmOX+GHCWpd0qOvGvQ@mail.gmail.com> (raw)
In-Reply-To: <CANeU7Q=x_DZzp93jP9AU5zpTuggR1AGa9pYqwi-kitXV5EKs0w@mail.gmail.com>
Hi Chris,
On 19 August 2017 at 11:56, Christopher Li <sparse@chrisli.org> wrote:
> On 8/19/17, Dibyendu Majumdar <mobile@majumdar.org.uk> wrote:
>> I think it is an excellent idea to create a bunch of careful tests to
>> assess / validate the changes. Perhaps the tests should cover various
>> scenarios including switch statements, gotos, computed gotos, looping
>> constructs, etc. And specific uses of globals, pointers, locals etc.
>>
>
> That is the idea for the test suite. To test how sparse handle
> different source code.
>
Yes. I have a growing set of tests but I only check the final result
is correct - i.e. the code can be run (both with and without
simplifications) and will produce expected results. I do not check
whether the Sparse IR is optimum or not, as I have been more focussed
on getting the right outcome.
> There is also the idea of the debug version of sparse. Instead
> having the fix input source. It will do dynamic verification
> of sparse at run time. e.g. If there is a slow and reliable way
> to generate SSA conversion. Then in the debug version will do
> both the slow and reliable way and the new fast and optimal way.
> Then compare notes to draw conclusion that the new way *is* better.
> AT least not worse than the old way. In this case I want to verify
> that, the new method at least cover all the variable converted
> by the old method. Including variable used by pointers.
>
Sure but this is kind of hard to do - because to validate something
you need a definition of what is "good" or "expected". Ideally of
course the output will be correct and at least as optimum as before -
but I would rather it is correct first.
Regards
Dibyendu
next prev parent reply other threads:[~2017-08-19 11:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-19 2:46 SSSA and some C pointer manipulation Christopher Li
2017-08-19 9:46 ` Dibyendu Majumdar
2017-08-19 10:56 ` Christopher Li
2017-08-19 11:57 ` Dibyendu Majumdar [this message]
2017-08-19 12:39 ` Christopher Li
2017-08-20 0:08 ` Luc Van Oostenryck
2017-08-20 0:33 ` Dibyendu Majumdar
2017-08-20 14:45 ` Luc Van Oostenryck
2017-08-20 16:18 ` Luc Van Oostenryck
2017-08-21 3:29 ` Christopher Li
2017-08-21 3:41 ` Christopher Li
2017-08-23 1:03 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACXZuxf-yb5WODCDJ2cQxJ2_sKUwSeKwAmOX+GHCWpd0qOvGvQ@mail.gmail.com \
--to=mobile@majumdar.org.uk \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).