From: Chris Li <sparse@chrisli.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Vincent Mailhol <mailhol@kernel.org>,
linux-sparse@vger.kernel.org,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] Warn about "unsigned value that used to be signed against zero"
Date: Wed, 24 Sep 2025 00:07:10 -0700 [thread overview]
Message-ID: <CACePvbUKV2rkYLeoQO9bWCon2qFkmKWGuh_NqvTccn=XZz7usw@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wgnre70y_EFdwMbxLcd3zzihFqFrDEVed7+P7cpUU74WA@mail.gmail.com>
On Mon, Sep 22, 2025 at 9:17 AM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Mon, 22 Sept 2025 at 05:10, Chris Li <sparse@chrisli.org> wrote:
> >
> > On Sun, Sep 21, 2025 at 8:16 AM Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> > >
> > > That's why I had added that
> > >
> > > info(def->pos, "signed value source");
> >
> > Do you want such a line in the final patch as well? Seems worth it.
>
> Oh, absolutely. Some of the cases it reported were really hard to
> understand without it.
>
> If it ends up being noisy, there could possibly be some heuristic like
> "if the source is very close to the use that triggers it, don't bother
> talking about it", but that would be a later tweak.
Vincent, can you add the above info() line suggested by Linus as
incremental or full patches?
I will try out the patch folding on sparse-dev.
Chris
next prev parent reply other threads:[~2025-09-24 7:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 6:12 [PATCH] Warn about "unsigned value that used to be signed against zero" Vincent Mailhol
2025-09-21 15:16 ` Linus Torvalds
2025-09-22 12:10 ` Chris Li
2025-09-22 16:16 ` Linus Torvalds
2025-09-24 7:07 ` Chris Li [this message]
2025-09-24 8:54 ` Vincent Mailhol
2025-09-24 17:44 ` Chris Li
2025-09-22 12:02 ` Chris Li
2025-09-22 13:00 ` Vincent Mailhol
2025-09-22 14:58 ` Chris Li
2025-09-22 15:53 ` [PATCH] vadidation: add used-to-be-signed unit tests Vincent Mailhol
2025-09-24 7:03 ` Chris Li
2025-09-24 9:27 ` Vincent Mailhol
2025-09-24 17:47 ` Chris Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACePvbUKV2rkYLeoQO9bWCon2qFkmKWGuh_NqvTccn=XZz7usw@mail.gmail.com' \
--to=sparse@chrisli.org \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=mailhol@kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).