linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] validation: add check for typeof() and address spaces
@ 2025-10-28 13:32 Dan Carpenter
  2025-12-01 15:24 ` Chris Li
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-10-28 13:32 UTC (permalink / raw)
  To: Chris Li, Uros Bizjak; +Cc: Sparse Mailing-list

The typeof() key word should preserve the address space and
typeof_unqual() should not.  Add a check to verify this works as
expected.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 validation/typeof-as.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 validation/typeof-as.c

diff --git a/validation/typeof-as.c b/validation/typeof-as.c
new file mode 100644
index 000000000000..563685281d92
--- /dev/null
+++ b/validation/typeof-as.c
@@ -0,0 +1,32 @@
+#define __seg_gs		__attribute__((address_space(__seg_gs)))
+static int __seg_gs m;
+
+static int __seg_gs bad_manual (void)
+{
+	return (*(int *)&m);
+}
+
+static int __seg_gs good_manual (void)
+{
+	return (*(int __seg_gs *)&m);
+}
+
+static int bad_typeof (void)
+{
+	return (*(typeof_unqual(m) *)&m);
+}
+
+static int __seg_gs good_typeof (void)
+{
+	return (*(volatile typeof(m) *)&m);
+}
+
+/*
+ * check-name: typeof address space
+ * check-command: ./sparse typeof-as.c
+ *
+ * check-error-start
+typeof-as.c:6:19: warning: cast removes address space '__seg_gs' of expression
+typeof-as.c:16:19: warning: cast removes address space '__seg_gs' of expression
+ * check-error-end
+ */
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] validation: add check for typeof() and address spaces
  2025-10-28 13:32 [PATCH] validation: add check for typeof() and address spaces Dan Carpenter
@ 2025-12-01 15:24 ` Chris Li
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Li @ 2025-12-01 15:24 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Uros Bizjak, Sparse Mailing-list

On Tue, Oct 28, 2025 at 5:32 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> The typeof() key word should preserve the address space and
> typeof_unqual() should not.  Add a check to verify this works as
> expected.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Applied to sparse-dev.

Chris

> ---
>  validation/typeof-as.c | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 validation/typeof-as.c
>
> diff --git a/validation/typeof-as.c b/validation/typeof-as.c
> new file mode 100644
> index 000000000000..563685281d92
> --- /dev/null
> +++ b/validation/typeof-as.c
> @@ -0,0 +1,32 @@
> +#define __seg_gs               __attribute__((address_space(__seg_gs)))
> +static int __seg_gs m;
> +
> +static int __seg_gs bad_manual (void)
> +{
> +       return (*(int *)&m);
> +}
> +
> +static int __seg_gs good_manual (void)
> +{
> +       return (*(int __seg_gs *)&m);
> +}
> +
> +static int bad_typeof (void)
> +{
> +       return (*(typeof_unqual(m) *)&m);
> +}
> +
> +static int __seg_gs good_typeof (void)
> +{
> +       return (*(volatile typeof(m) *)&m);
> +}
> +
> +/*
> + * check-name: typeof address space
> + * check-command: ./sparse typeof-as.c
> + *
> + * check-error-start
> +typeof-as.c:6:19: warning: cast removes address space '__seg_gs' of expression
> +typeof-as.c:16:19: warning: cast removes address space '__seg_gs' of expression
> + * check-error-end
> + */
> --
> 2.51.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-01 15:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-28 13:32 [PATCH] validation: add check for typeof() and address spaces Dan Carpenter
2025-12-01 15:24 ` Chris Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).