From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Dibyendu Majumdar <mobile@majumdar.org.uk>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: Possible incorrect linearization of code (master branch)
Date: Mon, 6 Mar 2017 20:26:12 +0100	[thread overview]
Message-ID: <CAExDi1RSA0qgBEbH8DH9w573-g1DrH4DhOrUo_GDdnKVh--F-w@mail.gmail.com> (raw)
In-Reply-To: <CACXZuxd_6YS7cficTeuPayyYCT-0Q==i3hje_Xd-MtoAP6bLyQ@mail.gmail.com>
On Mon, Mar 6, 2017 at 7:47 PM, Dibyendu Majumdar
<mobile@majumdar.org.uk> wrote:
> Okay thanks. I had originally started from the release 0.5 version of
> Sparse, and applied fixes selectively.
release 0.5 is quite old and a lot of patches have been added;
almost nothing related to correctness of LLVM but well about the correctness
of the linearization.
> Because I have a modified
> version of Sparse with all global state removed, merging changes is a
> bit painful as it has be done manually.
I can imagine this.
I, of course, hve no idea why you (have to) do this but I can only very strongly
advice you to try to avoid this as much as possible.
> That is why I have not been
> tracking sparse-next as I thought it is not yet stable. I have now
> merged all changes from master. Should I merge sparse-next now or wait
> for it to be merged into master?
It depends a bit you confortable you are with applying patches,
merging or rebasing
branches but as you have seen there is needed patches in sparse-next
that are not
yes in master although master was updated very recently.
It depends also about the nature of your changes, what is the
probability to have
nasty conflicts.
But idealy you would take very recent stuff but not too recent
(sparse-next itself may be
a bit too wild in the sense that the very top of it is often rebased).
-- Luc Van Oostenryck
next prev parent reply	other threads:[~2017-03-06 19:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-06 15:22 Possible incorrect linearization of code (master branch) Dibyendu Majumdar
2017-03-06 16:36 ` Luc Van Oostenryck
2017-03-06 18:47   ` Dibyendu Majumdar
2017-03-06 19:26     ` Luc Van Oostenryck [this message]
2017-03-06 22:39       ` Dibyendu Majumdar
2017-03-07  6:42         ` Luc Van Oostenryck
2017-03-07 15:45         ` Christopher Li
2017-03-07 17:13           ` Dibyendu Majumdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=CAExDi1RSA0qgBEbH8DH9w573-g1DrH4DhOrUo_GDdnKVh--F-w@mail.gmail.com \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=mobile@majumdar.org.uk \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).