linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Dibyendu Majumdar <mobile@majumdar.org.uk>
Cc: Christopher Li <sparse@chrisli.org>,
	Linux-Sparse <linux-sparse@vger.kernel.org>,
	Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Lance Richardson <lrichard@redhat.com>,
	Michael Stefaniuc <mstefani@mykolab.com>
Subject: Re: Sparse 0.5.1 RC5 released.
Date: Sun, 13 Aug 2017 16:25:20 +0200	[thread overview]
Message-ID: <CAExDi1R_6W3wysxR5bNPZ5PYDhgwo+Q=tJdL1QaV9dOXwyM27w@mail.gmail.com> (raw)
In-Reply-To: <CAExDi1TftYYi=CS09_yUdMP0xni3zwq-ZJoRz3hEWgykiybLpQ@mail.gmail.com>

> OTOH with -rc4, it takes only 0.05s !
>
> The situation is really weird, it's an interaction between the patches:
> - remove single-store shortcut (first slowdown to 0.8s)
> - fix ptrlist corruption while killing unreachable BBs (second slowdown to 2.9s)
> - mark pseudo users as deleted instead of removing them (third slowdown to 5.5s)
>
> All three patches were expected to create *some* slowdown,
> the first one very obviously and much more than the others.
>
> It's interesting to note that without the 'remove single shortcut' patch, the
> two others ones don't seem to have a significative effect on the time.
>
> My guess here is that indeed, with this input, the single-store shortcut
> is a huge optimization and without it much much more code is created
> (phi-nodes, I suppose) and this impact very negatively the two other fixes.
>
> I'll see what can be done.

It's also interesting to note that with the new SSA construction, there is no
slowdown (0.064s here but too small to be measured accurately).
This confirms me that the single-store shortcut was very much needed for
performance (not simply because it's faster than the general case but that
it creates much less intermediate code) but it created bad code ...

-- Luc

  reply	other threads:[~2017-08-13 14:25 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-12 14:15 Sparse 0.5.1 RC5 released Christopher Li
2017-08-12 20:26 ` Michael Stefaniuc
2017-08-12 20:51   ` Luc Van Oostenryck
2017-08-12 21:36 ` Ramsay Jones
2017-08-12 21:41   ` Christopher Li
2017-08-13 12:56 ` Dibyendu Majumdar
2017-08-13 13:10   ` Luc Van Oostenryck
2017-08-13 13:18     ` Dibyendu Majumdar
2017-08-13 13:54       ` Dibyendu Majumdar
2017-08-13 14:24         ` Dibyendu Majumdar
2017-08-13 14:18       ` Luc Van Oostenryck
2017-08-13 14:25         ` Luc Van Oostenryck [this message]
2017-08-13 14:26           ` Dibyendu Majumdar
2017-08-13 15:07             ` Luc Van Oostenryck
2017-08-13 15:12               ` Dibyendu Majumdar
2017-08-13 16:40           ` Luc Van Oostenryck
2017-08-13 14:44         ` Dibyendu Majumdar
2017-08-13 15:00           ` Dibyendu Majumdar
2017-08-13 15:13             ` Luc Van Oostenryck
2017-08-13 19:03   ` Christopher Li
2017-08-13 19:10     ` Dibyendu Majumdar
2017-08-13 19:20       ` Christopher Li
2017-08-13 19:56         ` Dibyendu Majumdar
2017-08-13 20:09       ` Luc Van Oostenryck
2017-08-13 20:20         ` Dibyendu Majumdar
2017-08-13 21:16           ` Luc Van Oostenryck
2017-08-13 22:12             ` Dibyendu Majumdar
2017-08-13 22:36               ` Luc Van Oostenryck
2017-08-13 22:50                 ` Dibyendu Majumdar
2017-08-13 23:03                   ` Luc Van Oostenryck
2017-08-13 22:55                 ` Dibyendu Majumdar
2017-08-13 23:10                   ` Luc Van Oostenryck
2017-08-13 23:17                     ` Dibyendu Majumdar
2017-08-13 23:20                       ` Dibyendu Majumdar
2017-08-13 23:28                         ` Luc Van Oostenryck
2017-08-13 23:35                           ` Dibyendu Majumdar
2017-08-13 23:40                             ` Luc Van Oostenryck
2017-08-13 23:44                               ` Dibyendu Majumdar
2017-08-13 23:22                       ` Luc Van Oostenryck
2017-08-13 23:25                         ` Dibyendu Majumdar
2017-08-13 23:35                           ` Luc Van Oostenryck
2017-08-13 23:42                             ` Dibyendu Majumdar
2017-08-13 23:47                               ` Luc Van Oostenryck
2017-08-13 23:58                                 ` Luc Van Oostenryck
2017-08-14  0:30                                   ` Luc Van Oostenryck
2017-08-14  0:30               ` Christopher Li
2017-08-14  0:34                 ` Luc Van Oostenryck
2017-08-14  0:36                   ` Christopher Li
2017-08-14 18:48                 ` Dibyendu Majumdar
2017-08-14 18:52                   ` Christopher Li
2017-08-14 18:56                     ` Christopher Li
2017-08-14 18:58                     ` Dibyendu Majumdar
2017-08-14 19:23                       ` Christopher Li
2017-08-14 19:47                         ` Christopher Li
2017-08-14 20:30                           ` Christopher Li
2017-08-14 16:15           ` Luc Van Oostenryck
2017-08-14 16:17             ` Dibyendu Majumdar
2017-08-14 16:25               ` Luc Van Oostenryck
2017-08-14 16:29                 ` Dibyendu Majumdar
2017-08-14 16:44                   ` Luc Van Oostenryck
2017-08-14 16:54                     ` Dibyendu Majumdar
2017-08-14 18:51                       ` Luc Van Oostenryck
2017-08-14 18:24     ` Christopher Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAExDi1R_6W3wysxR5bNPZ5PYDhgwo+Q=tJdL1QaV9dOXwyM27w@mail.gmail.com' \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=lrichard@redhat.com \
    --cc=mobile@majumdar.org.uk \
    --cc=mstefani@mykolab.com \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).