From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luc Van Oostenryck Subject: Re: [PATCH 09/29] add helper to test if a variable is "simple" Date: Fri, 18 Aug 2017 22:27:54 +0200 Message-ID: References: <20170816153455.97693-1-luc.vanoostenryck@gmail.com> <20170816153455.97693-10-luc.vanoostenryck@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-oi0-f65.google.com ([209.85.218.65]:34650 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586AbdHRU14 (ORCPT ); Fri, 18 Aug 2017 16:27:56 -0400 Received: by mail-oi0-f65.google.com with SMTP id v11so10350502oif.1 for ; Fri, 18 Aug 2017 13:27:55 -0700 (PDT) In-Reply-To: Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Christopher Li Cc: Dibyendu Majumdar , Linux-Sparse , Linus Torvalds On Fri, Aug 18, 2017 at 10:14 PM, Christopher Li wrote: > On Fri, Aug 18, 2017 at 3:21 PM, Luc Van Oostenryck wrote: > >> The points that matter to me are: >> 1) generate correct SSA information. >> This is ultra-important because with incorrect SSA >> a lot of the optimizations are wrong, introduce errors >> and infinite loops or need ugly workarounds. > > That I totally agree. Incorrect SSA can't not use as SSA at all. > >> 2) correct any other issues sparse could have with the generated IR >> 3) correct any errors sparse could have with an optimization >> 4) add support for construct sparse doesn't support yet >> 5) add more features, make the sparse's code more efficient >> and the generated IR too. > > All agree. > >> 5') do not forget that sparse is firstly the/a C checker for the kernel >> (and others projects). > > Sure. But sparse need to get good IR to perform the checking. Hence, points 2 & 3 :) -- Luc