linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Dibyendu Majumdar <mobile@majumdar.org.uk>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: Potential problem with variable handling - Was: Handling of local variables in the backend
Date: Wed, 13 Sep 2017 15:42:56 +0200	[thread overview]
Message-ID: <CAExDi1T=oVvh5R9PJbw3pydPBSiJw27Vq_bSBgrXBYP1-wGO1g@mail.gmail.com> (raw)
In-Reply-To: <CACXZuxexegxsogqdWgwWvLTC554X_sZsHUqd39g-jTJfHHpgNQ@mail.gmail.com>

On Wed, Sep 13, 2017 at 3:07 PM, Dibyendu Majumdar
<mobile@majumdar.org.uk> wrote:
> Hi Luc,
>
> On 13 September 2017 at 12:55, Luc Van Oostenryck
> <luc.vanoostenryck@gmail.com> wrote:
>> On Wed, Sep 13, 2017 at 1:37 PM, Dibyendu Majumdar
>> <mobile@majumdar.org.uk> wrote:
>>> Hi,
>>>
>>>
>>> I have been thinking about this issue for some time - i.e. that the
>>> Sparse IR does not explicitly define or initialize local variables.
>>
>> The problem of undefined variables is one thing (that the SSA conversion
>> can and should deal with).
>>
>>> The back-end deals with it by doing it at first access. But this could
>>> result in incorrect behavior if the initialization was meant to occur
>>> at a certain point in the code. I should probably try to prove this
>>> theory by creating a test - but intuitively it seems that if the
>>> programmer had meant to initialize a variable at a particular point,
>>> there could be a reason why it should be done at that point and not
>>> some point later.
>>
>> Unless you access the variables by some means the compiler is not aware
>> of, it must not matter.
>>
>> And in all case, the initialization must be done when the following rules
>> (scopes, sequence points, ...) and the compiler is free to do anything
>> 'as if' these rules are respected.
>>
>
> Yes, it seems this is okay as the store instruction (from
> initialization) occurs at the right place.

Yes, but the 'place' (or 'time') is not the right concept.
The only thing that matter is for subsequent loads to see the
correct values. Thus everything is legit and correct as long as
the store-load dependencies are respected.
If you use pointers or if the variables can be in one way or another
be aliased between each other, then it's not simply the store-load
dependencies of this variable that must be respected but all
(possible) dependencies between all aliases (and partial aliases).

-- Luc

      reply	other threads:[~2017-09-13 13:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 11:37 Potential problem with variable handling - Was: Handling of local variables in the backend Dibyendu Majumdar
2017-09-13 11:55 ` Luc Van Oostenryck
2017-09-13 13:07   ` Dibyendu Majumdar
2017-09-13 13:42     ` Luc Van Oostenryck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAExDi1T=oVvh5R9PJbw3pydPBSiJw27Vq_bSBgrXBYP1-wGO1g@mail.gmail.com' \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=mobile@majumdar.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).