From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 3/6] build: drop BASIC_CFLAGS and ALL_CFLAGS
Date: Wed, 1 Nov 2017 18:05:11 +0100 [thread overview]
Message-ID: <CAExDi1TH6RuJX32wnWavx84ndwsmvwWdFG__SJeCjFPeSOMUoA@mail.gmail.com> (raw)
In-Reply-To: <CANeU7QmRzBJde5t4_tJ6pog3uAz8aP34NX6ozZnno638w_Ahug@mail.gmail.com>
On Fri, Oct 6, 2017 at 9:09 PM, Christopher Li <sparse@chrisli.org> wrote:
> On Wed, Oct 4, 2017 at 6:26 AM, Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
>> There is no good reason to not use plain CFLAGS for all usages.
>> This simplifies understanding the Makefile for the casual reader.
>
> Have more fine grain variable allow partial overwrite some
> part of the CFLAG in some specific locations. For example
> some flags have order over other flags etc.
And having several names make possible to use the wrong name.
> I don't see a strong reason to change it. The change did not gain
> any function.
Your version of the patch has (at least) two bugs that aren't present in this
version *because* this version (or mine) use the plain CFLAGS for everything.
-- Luc
next prev parent reply other threads:[~2017-11-01 17:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 13:25 [PATCH 0/6] build: various updates Uwe Kleine-König
2017-10-04 13:26 ` [PATCH 1/6] build: make PREFIX overwritable from the environment Uwe Kleine-König
2017-10-04 13:26 ` [PATCH 2/6] build: put comment about local.mk to the place where it is included Uwe Kleine-König
2017-10-06 19:04 ` Christopher Li
2017-10-04 13:26 ` [PATCH 3/6] build: drop BASIC_CFLAGS and ALL_CFLAGS Uwe Kleine-König
2017-10-06 19:09 ` Christopher Li
2017-11-01 17:05 ` Luc Van Oostenryck [this message]
2017-10-04 13:26 ` [PATCH 4/6] build: drop -g from LDFLAGS Uwe Kleine-König
2017-10-06 19:14 ` Christopher Li
2017-10-04 13:26 ` [PATCH 5/6] build: pass standard make variables to compiler and linker Uwe Kleine-König
2017-11-04 6:43 ` Luc Van Oostenryck
2017-10-04 13:26 ` [PATCH 6/6] build: replace *_EXTRA_OBJS by local assignments to LDFLAGS and LOADLIBES Uwe Kleine-König
2017-10-06 19:19 ` Christopher Li
2017-11-04 13:10 ` Luc Van Oostenryck
2017-10-06 19:03 ` [PATCH 0/6] build: various updates Christopher Li
[not found] ` <e3d57acc-e699-f51d-6687-e1535db4cd46@kleine-koenig.org>
2017-10-06 21:30 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAExDi1TH6RuJX32wnWavx84ndwsmvwWdFG__SJeCjFPeSOMUoA@mail.gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).