* Re: warning: cast removes address space '__percpu' of expression [not found] ` <CAFULd4ahxmEiJ37hLXUg3RwZMW9GnkN=38ZuirSq_cu3VHMU0g@mail.gmail.com> @ 2024-04-03 7:14 ` Charlemagne Lasse 2024-04-22 7:22 ` Charlemagne Lasse 0 siblings, 1 reply; 2+ messages in thread From: Charlemagne Lasse @ 2024-04-03 7:14 UTC (permalink / raw) To: Uros Bizjak, linux-sparse Cc: x86, LKML, Luc Van Oostenryck, Andy Lutomirski, Ingo Molnar, Brian Gerst, Denys Vlasenko, H . Peter Anvin, Peter Zijlstra, Thomas Gleixner, Borislav Petkov, Josh Poimboeuf Am Di., 2. Apr. 2024 um 22:40 Uhr schrieb Uros Bizjak <ubizjak@gmail.com>: [snip] > > ``` > > git reset --hard ed2f752e0e0a21d941ca0ee539ef3d4cd576bc5e > > git cherry-pick 3a1d3829e193c091475ceab481c5f8deab385023 > > patch -p1 -i ~/p.diff.txt > > git clean -dfx > > make allnoconfig -j$(nproc) > > make kvm_guest.config > > echo CONFIG_MODULES=y >> .config > > echo CONFIG_NET_9P_VIRTIO=m >> .config > > make olddefconfig > > make prepare -j$(nproc) > > touch net/9p/trans_virtio.c > > make C=1 M=net/9p/ trans_virtio.o CHECK="sparse -Wconstexpr-not-const" > > ``` > > > > This now shows the warning: > > > > ``` > > net/9p/trans_virtio.c:831:1: warning: non-constant initializer for static object > > net/9p/trans_virtio.c:832:1: warning: non-constant initializer for static object > > ``` [snip] > It's this part: > > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > index d7779a18b24fc3..bf9815eaf4aabf 100644 > --- a/include/linux/compiler.h > +++ b/include/linux/compiler.h > @@ -212,7 +212,7 @@ void ftrace_likely_update(struct > ftrace_likely_data *f, int val, > */ > #define ___ADDRESSABLE(sym, __attrs) \ > static void * __used __attrs \ > - __UNIQUE_ID(__PASTE(__addressable_,sym)) = (void *)&sym; > + __UNIQUE_ID(__PASTE(__addressable_,sym)) = (void *)(uintptr_t)&sym; > #define __ADDRESSABLE(sym) \ > ___ADDRESSABLE(sym, __section(".discard.addressable")) > > But ... how is this not const? @Luc Van Oostenryck Do you have any idea how to correctly implement it to make sparse happy? ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: warning: cast removes address space '__percpu' of expression 2024-04-03 7:14 ` warning: cast removes address space '__percpu' of expression Charlemagne Lasse @ 2024-04-22 7:22 ` Charlemagne Lasse 0 siblings, 0 replies; 2+ messages in thread From: Charlemagne Lasse @ 2024-04-22 7:22 UTC (permalink / raw) To: Uros Bizjak, linux-sparse Cc: x86, LKML, Luc Van Oostenryck, Andy Lutomirski, Ingo Molnar, Brian Gerst, Denys Vlasenko, H . Peter Anvin, Peter Zijlstra, Thomas Gleixner, Borislav Petkov, Josh Poimboeuf Am Mi., 3. Apr. 2024 um 09:14 Uhr schrieb Charlemagne Lasse <charlemagnelasse@gmail.com>: > > Am Di., 2. Apr. 2024 um 22:40 Uhr schrieb Uros Bizjak <ubizjak@gmail.com>: > [snip] > > > ``` > > > git reset --hard ed2f752e0e0a21d941ca0ee539ef3d4cd576bc5e > > > git cherry-pick 3a1d3829e193c091475ceab481c5f8deab385023 > > > patch -p1 -i ~/p.diff.txt > > > git clean -dfx > > > make allnoconfig -j$(nproc) > > > make kvm_guest.config > > > echo CONFIG_MODULES=y >> .config > > > echo CONFIG_NET_9P_VIRTIO=m >> .config > > > make olddefconfig > > > make prepare -j$(nproc) > > > touch net/9p/trans_virtio.c > > > make C=1 M=net/9p/ trans_virtio.o CHECK="sparse -Wconstexpr-not-const" > > > ``` > > > > > > This now shows the warning: > > > > > > ``` > > > net/9p/trans_virtio.c:831:1: warning: non-constant initializer for static object > > > net/9p/trans_virtio.c:832:1: warning: non-constant initializer for static object > > > ``` > [snip] > > It's this part: > > > > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > > index d7779a18b24fc3..bf9815eaf4aabf 100644 > > --- a/include/linux/compiler.h > > +++ b/include/linux/compiler.h > > @@ -212,7 +212,7 @@ void ftrace_likely_update(struct > > ftrace_likely_data *f, int val, > > */ > > #define ___ADDRESSABLE(sym, __attrs) \ > > static void * __used __attrs \ > > - __UNIQUE_ID(__PASTE(__addressable_,sym)) = (void *)&sym; > > + __UNIQUE_ID(__PASTE(__addressable_,sym)) = (void *)(uintptr_t)&sym; > > #define __ADDRESSABLE(sym) \ > > ___ADDRESSABLE(sym, __section(".discard.addressable")) > > > > But ... how is this not const? > > @Luc Van Oostenryck Do you have any idea how to correctly implement it > to make sparse happy? ping? ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-22 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAFGhKbzev7W4aHwhFPWwMZQEHenVgZUj7=aunFieVqZg3mt14A@mail.gmail.com>
[not found] ` <CAFULd4a75kS=3cJzYKsOcJ3ULjW8k5M1cvPYZQ25zZqTo3QX9Q@mail.gmail.com>
[not found] ` <CAFGhKbx3dzrMC0euRMNe5=sAhM87v=6gLwOT+c9HwWKZrWc5Gg@mail.gmail.com>
[not found] ` <CAFULd4ZNi7eONVu8syiWyA5ek2TgHTf6jTM+Pf7SaSG6WyHoNw@mail.gmail.com>
[not found] ` <CAFGhKbwqrr=_bOnKW+wqtX2OyW0xpS_9wkJnHpwxmwx7MHGhfg@mail.gmail.com>
[not found] ` <CAFGhKbzdWLw7fmRTLYPhEycWZvfjE-OCvnWct2A_kWVe94-p-A@mail.gmail.com>
[not found] ` <CAFULd4ahxmEiJ37hLXUg3RwZMW9GnkN=38ZuirSq_cu3VHMU0g@mail.gmail.com>
2024-04-03 7:14 ` warning: cast removes address space '__percpu' of expression Charlemagne Lasse
2024-04-22 7:22 ` Charlemagne Lasse
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).