From: Nick Desaulniers <ndesaulniers@google.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
dan.carpenter@oracle.com, adilger.kernel@dilger.ca,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
rostedt@goodmis.org, mchehab+samsung@kernel.org, olof@lxom.net,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Paul Lawrence <paullawrence@google.com>,
sandipan@linux.vnet.ibm.com,
Andrey Konovalov <andreyknvl@google.com>,
David Woodhouse <dwmw2@infradead.org>,
Will Deacon <will.deacon@arm.com>,
Philippe Ombredanne <pombredanne@nexb.com>
Subject: Re: [PATCH 0/2] Compiler Attributes: __fallthrough
Date: Mon, 22 Oct 2018 09:54:27 -0700 [thread overview]
Message-ID: <CAKwvOdn9hOcF01eOmwfnrH_ciFZ4fPaspSzMPiY68o3B0En-VQ@mail.gmail.com> (raw)
In-Reply-To: <CANiq72kOE0a4M0oCmmiWO9xTFJsybEirwUyb_ZTXpJJhc7O_TA@mail.gmail.com>
On Mon, Oct 22, 2018 at 2:48 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Sun, Oct 21, 2018 at 8:29 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > Will this work with all of the static tools that are currently looking
> > for the comment instead? I know coverity handles that, what about
> > others?
>
> I will also contact the different tools about this.
Let's contact the authors of these tools if they don't parse the
attribute. I prefer to have the attributes rather than specifically
formatted comments.
I do think this may be tricky to provide backwards support for though;
Miguel, do you have info on which versions of GCC support comments vs
attribute?
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2018-10-22 16:54 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 17:14 [PATCH 0/2] Compiler Attributes: __fallthrough Miguel Ojeda
2018-10-21 17:14 ` [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1) Miguel Ojeda
2018-10-21 22:27 ` Theodore Y. Ts'o
[not found] ` <8fb78062-b6d4-6f2d-d943-44bec6b95ff0@petrovitsch.priv.at>
2018-10-22 10:27 ` Dan Carpenter
2018-10-22 10:45 ` Bernd Petrovitsch
2018-10-22 10:53 ` Dan Carpenter
2018-10-22 11:07 ` Miguel Ojeda
2018-10-22 17:49 ` Bernd Petrovitsch
2018-10-22 17:54 ` Nick Desaulniers
2018-10-22 18:13 ` Bernd Petrovitsch
2018-10-22 21:34 ` Miguel Ojeda
2018-10-22 17:26 ` Nick Desaulniers
[not found] ` <CANiq72mXV6WTyHXNZJDTfFOpPrXD0zD6cB30bGOuKO44AvRiog@mail.gmail.com>
2018-10-22 9:34 ` Kees Cook
2018-10-22 9:41 ` Miguel Ojeda
2018-10-22 9:43 ` Miguel Ojeda
2018-10-22 17:17 ` Nick Desaulniers
2018-10-22 20:59 ` Miguel Ojeda
2018-10-22 10:53 ` Kees Cook
2018-10-22 11:24 ` Miguel Ojeda
2018-10-22 13:39 ` Miguel Ojeda
2018-10-22 17:23 ` Nick Desaulniers
2018-10-22 0:42 ` Matthew Wilcox
2018-10-22 6:58 ` Theodore Y. Ts'o
2018-10-22 9:32 ` Miguel Ojeda
2018-10-22 12:07 ` Luc Van Oostenryck
2018-10-22 12:09 ` Miguel Ojeda
2018-10-22 17:36 ` Nick Desaulniers
2018-10-22 21:17 ` Miguel Ojeda
2018-10-21 17:14 ` [PATCH 2/2] Compiler Attributes: auxdisplay: panel: use __fallthrough Miguel Ojeda
2018-10-21 18:11 ` Joe Perches
2018-10-22 9:51 ` Miguel Ojeda
2018-10-22 15:48 ` Joe Perches
2018-10-22 14:10 ` Kees Cook
[not found] ` <20181023053542.lsklua2p3lnbkqir@mwanda>
2018-11-02 10:49 ` Miguel Ojeda
2018-11-02 10:56 ` Miguel Ojeda
2018-10-21 18:29 ` [PATCH 0/2] Compiler Attributes: __fallthrough Greg Kroah-Hartman
2018-10-21 18:52 ` Joe Perches
2018-10-22 5:27 ` Dan Carpenter
2018-10-22 9:48 ` Miguel Ojeda
2018-10-22 16:54 ` Nick Desaulniers [this message]
2018-10-22 21:23 ` Miguel Ojeda
2018-10-23 5:43 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdn9hOcF01eOmwfnrH_ciFZ4fPaspSzMPiY68o3B0En-VQ@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=adilger.kernel@dilger.ca \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@kernel.org \
--cc=olof@lxom.net \
--cc=paullawrence@google.com \
--cc=pombredanne@nexb.com \
--cc=rostedt@goodmis.org \
--cc=sandipan@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).