From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Desaulniers Subject: Re: [PATCH 0/2] Compiler Attributes: __fallthrough Date: Mon, 22 Oct 2018 09:54:27 -0700 Message-ID: References: <20181021171414.22674-1-miguel.ojeda.sandonis@gmail.com> <20181021182926.GB6683@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Miguel Ojeda Cc: Greg KH , LKML , dan.carpenter@oracle.com, adilger.kernel@dilger.ca, Masahiro Yamada , Michal Marek , rostedt@goodmis.org, mchehab+samsung@kernel.org, olof@lxom.net, Konstantin Ryabitsev , "David S. Miller" , Andrey Ryabinin , Kees Cook , Thomas Gleixner , Ingo Molnar , Paul Lawrence , sandipan@linux.vnet.ibm.com, Andrey Konovalov , David Woodhouse , Will Deacon , Philippe Ombredanne List-Id: linux-sparse@vger.kernel.org On Mon, Oct 22, 2018 at 2:48 AM Miguel Ojeda wrote: > > On Sun, Oct 21, 2018 at 8:29 PM Greg Kroah-Hartman > wrote: > > > > Will this work with all of the static tools that are currently looking > > for the comment instead? I know coverity handles that, what about > > others? > > I will also contact the different tools about this. Let's contact the authors of these tools if they don't parse the attribute. I prefer to have the attributes rather than specifically formatted comments. I do think this may be tricky to provide backwards support for though; Miguel, do you have info on which versions of GCC support comments vs attribute? -- Thanks, ~Nick Desaulniers