From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>,
Chris Li <sparse@chrisli.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 3/3] add support for -fmemcpy-max-count
Date: Fri, 2 Jun 2017 03:45:07 +0200 [thread overview]
Message-ID: <CAMHZB6EtTDXkDLKumGnyBm9n3vbNNEGLnGqT9mndL+r77q2emA@mail.gmail.com> (raw)
In-Reply-To: <faa88d94-b243-e8be-39f0-b84ccbf92ba0@ramsayjones.plus.com>
On Fri, Jun 2, 2017 at 3:42 AM, Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>> Well, for now setting the limit to 0 would just warn about any
>> non-zero memcpy/memset
>> but it's something that could very easily be added, sure.
>
> Yes, as I noted in another email, I didn't read the code correctly!
> (and in my patch I had a single -Wmem-limit=n argument which _did_
> disable the check when n = 0).
>
> Naming issues aside (and I'm bad at naming, so don't listen to me
> on that), I like your -W[no-]memcpy-max-count and -fmemcpy-limit=n
> split.
>
> [You may want to remove the '=COUNT' from the commit message of
> the 2/3 patch].
Oh yes, indeed.
Thanks.
-- Luc
next prev parent reply other threads:[~2017-06-02 1:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <84e547c2-8a5b-225c-1363-361e091821f4@ramsayjones.plus.com>
2017-06-01 20:27 ` [PATCH 0/3] -Wmemcpy-max-count & friends Luc Van Oostenryck
2017-06-01 20:27 ` [PATCH 1/3] memcpy()'s byte count is unsigned Luc Van Oostenryck
2017-06-02 0:16 ` Ramsay Jones
2017-06-02 1:17 ` Luc Van Oostenryck
2017-06-01 20:27 ` [PATCH 2/3] add support for -Wmemcpy-max-count Luc Van Oostenryck
2017-06-02 0:23 ` Ramsay Jones
2017-06-02 0:33 ` Luc Van Oostenryck
2017-06-01 20:27 ` [PATCH 3/3] add support for -fmemcpy-max-count Luc Van Oostenryck
2017-06-02 0:30 ` Ramsay Jones
2017-06-02 0:37 ` Ramsay Jones
2017-06-02 0:38 ` Luc Van Oostenryck
2017-06-02 1:42 ` Ramsay Jones
2017-06-02 1:45 ` Luc Van Oostenryck [this message]
2017-06-02 0:11 ` [PATCH 0/3] -Wmemcpy-max-count & friends Ramsay Jones
2017-06-02 0:26 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMHZB6EtTDXkDLKumGnyBm9n3vbNNEGLnGqT9mndL+r77q2emA@mail.gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=gitster@pobox.com \
--cc=linux-sparse@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).