From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luc Van Oostenryck Subject: Re: [PATCH] build: assign extra flags to ALL_CFLAGS instead of CFLAGS Date: Wed, 18 Oct 2017 21:41:21 +0200 Message-ID: References: <20171018150727.26821-1-jlayton@kernel.org> <1508339545.4628.4.camel@poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-ua0-f174.google.com ([209.85.217.174]:55941 "EHLO mail-ua0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbdJRTlW (ORCPT ); Wed, 18 Oct 2017 15:41:22 -0400 Received: by mail-ua0-f174.google.com with SMTP id b11so4393814uae.12 for ; Wed, 18 Oct 2017 12:41:22 -0700 (PDT) In-Reply-To: <1508339545.4628.4.camel@poochiereds.net> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Jeff Layton Cc: Linux-Sparse On Wed, Oct 18, 2017 at 5:12 PM, Jeff Layton wrote: > > The fedora packaging tools want to override $CFLAGS when building > sparse, but that fails on a couple of targets. > > There are a couple of build targets in the makefile that want to add > options to $CFLAGS. When we do a build though, we pass $ALL_CFLAGS to > the compiler, and that ends up without those extra options, if CFLAGS= > was specified on the command line. > > I'm not sure if this is a recursive variable expansion bug in make, but I think it's just an effect of CFLAGS being then used as a target-specific variable -- Luc